add validation on hostPath and update comments

Author: prasebha

charts/mgmt-agent/templates/mgmt-agent-daemonset.yaml

@@ -96,7 +96,10 @@ spec:
             name: {{ include "mgmt-agent.resourceNamePrefix" . }}-agent
         - name: mgmtagent-hostpath
           hostPath: 
-            path: "{{ required "deployment.daemonSet.hostPath is required" .Values.deployment.daemonSet.hostPath }}/daemonset-mgmtagent-container"
+            path: "{{ required "deployment.daemonSet.hostPath is required" .Values.deployment.daemonSet.hostPath }}"
+            {{- if regexMatch "^/opt/oracle/*$" .Values.deployment.daemonSet.hostPath }}
+            {{- fail "Error: deployment.daemonSet.hostPath cannot be /opt/oracle. Please provide another location or create a sub-directory under /opt/oracle and use that as hostPath" }}
+            {{- end }}
         - emptyDir: {}
           name: tmp
 {{- end }}

charts/mgmt-agent/values.yaml

@@ -84,11 +84,10 @@ deployment:
    daemonSetDeployment: false
 
    daemonSet:
-      # Provide the host path (defaults to /opt/oracle, please change if required) if Agent is deployed as DaemonSet. Management Agent Pod should have read-write access to it.
-      # The host path needs to be owned by runAsUser and runAsGroup, provided under security context above.
-      # Note: The deployment will create a sub directory i.e. daemonset-mgmtagent-container under the the provided hostPath.
-      hostPath: /opt/oracle
-      # Override the ownership and permissions on the hostPath, to be owned by the runAsUser and runAsGroup provided under security context above and the permission as 750. 
+      # Provide the host path if Agent is deployed as DaemonSet. Management Agent Pod should have read-write access to it.
+      # Note: The hostPath cannot point to /opt/oracle, please provide another location or create a sub-directory under /opt/oracle and use that as hostPath 
+      hostPath:
+      # Override the ownership and permissions on the hostPath. The hostPath will be owned by the runAsUser and runAsGroup provided under security context above and the permission as 750. 
       # Note: This requires oraclelinux:8-slim image
       # Setting overrideOwnership to false will disable the ownership change.
       overrideOwnership: true