Skip to content

Commit 35ae500

Browse files
committed
Github Actions: eliminate cache
I had hoped that storing kernel and debuginfo RPMs in a cache would improve the runtime of the actions by reducing the amount of downloads. But I haven't seen much in the way of improvement on the runtime when the cache was working, and the cache has caused *several* failures for pull requests and CI. Most developers don't have push access and therefore can't use the "re-run job" button. It seems like the cache just isn't helping, so let's get rid of it. Signed-off-by: Stephen Brennan <[email protected]>
1 parent 5426f15 commit 35ae500

File tree

1 file changed

+0
-26
lines changed

1 file changed

+0
-26
lines changed

.github/workflows/litevm.yml

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -63,32 +63,6 @@ jobs:
6363
tox list
6464
tox --notest
6565
tox -e runner --notest
66-
67-
# Use Github Actions to cache RPMs by date. This can save a couple minutes
68-
# in the run, which is nice. The cache contains the Yum sqlite database,
69-
# and the downloaded RPMs.
70-
#
71-
# A cache miss results in getting the most recent cached data (e.g. from
72-
# yesterday). The runner will check the repo metadata and get the updated
73-
# data, and delete any stale data, so after the run completes, the
74-
# testdata can be cached for future runs.
75-
#
76-
# On a cache hit, the test runner will still check the yum repo metadata,
77-
# and if it differs from the cached data, it will clear and download it.
78-
# So a cache hit isn't guaranteed to speed things up, but kernel packages
79-
# aren't usually updated _that_ frequently.
80-
- name: Get Date
81-
id: get-date
82-
run: |
83-
echo "date=$(/bin/date -u "+%Y%m%d")" >> $GITHUB_OUTPUT
84-
shell: bash
85-
- name: Cache RPMs
86-
uses: actions/cache@v3
87-
with:
88-
path: testdata/yumcache
89-
key: ${{ runner.os }}-rpms-${{ steps.get-date.outputs.date }}
90-
restore-keys: |
91-
${{ runner.os }}-rpms-
9266
- name: Fetch RPMs
9367
run: |
9468
tox -e runner -- python -m testing.litevm.rpm

0 commit comments

Comments
 (0)