Skip to content

Commit 7eafc49

Browse files
committed
rds: don't operate for rds_tcp
The current code implicitly assumes that the system is using rds_rdma. If the module runs on a system with rds_tcp loaded, we get a traceback ending in the following error: KeyError: 'rds_ib_devices' I don't know whether rds_tcp support is desired at this time, but at a minimum, corelens should not throw a traceback. So, explicitly require rds_rdma for this module. Now, for rds_tcp, we get the following standard corelens warning that explains the situation. warning: rds skipped because 'rds, rds_rdma' was (were) not (all) loaded in the kernel Orabug: 37502613 Signed-off-by: Stephen Brennan <[email protected]>
1 parent 722b67c commit 7eafc49

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drgn_tools/rds.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1540,7 +1540,7 @@ class Rds(CorelensModule):
15401540
"""Print info about RDS devices, sockets, connections, and stats"""
15411541

15421542
name = "rds"
1543-
skip_unless_have_kmods = ["rds"]
1543+
skip_unless_have_kmods = ["rds_rdma", "rds"]
15441544

15451545
# We access information from the following modules #
15461546
debuginfo_kmods = ["mlx5_core", "mlx4_core", "mlx5_ib", "mlx4_ib"]

0 commit comments

Comments
 (0)