Merge pull request #111 from oracle-samples/nullable-boolean

Correctly handle nil pointer values for nullable columns

Author: ting-lan-wang

oracle/common.go

@@ -218,6 +218,10 @@ func convertValue(val interface{}) interface{} {
 
 	// Dereference pointers
 	rv := reflect.ValueOf(val)
+	if rv.Kind() == reflect.Ptr && rv.IsNil() {
+		return nil
+	}
+
 	for rv.Kind() == reflect.Ptr && !rv.IsNil() {
 		rv = rv.Elem()
 		val = rv.Interface()

tests/boolean_test.go

@@ -259,9 +259,8 @@ func TestBooleanStringCoercion(t *testing.T) {
 	}
 }
 
-
 func TestBooleanNullableColumn(t *testing.T) {
-	t.Skip("Skipping until nullable bool bug is resolved")
+	// t.Skip("Skipping until nullable bool bug is resolved")
 	DB.Migrator().DropTable(&BooleanTest{})
 	DB.AutoMigrate(&BooleanTest{})