Skip to content

Commit 06a49b4

Browse files
fixed tests
1 parent 6ba9abe commit 06a49b4

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

oracle/common.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -450,6 +450,8 @@ func isNullValue(value interface{}) bool {
450450

451451
// Check for different NULL types
452452
switch v := value.(type) {
453+
case sql.NullString:
454+
return !v.Valid
453455
case sql.NullInt64:
454456
return !v.Valid
455457
case sql.NullInt32:

tests/passed-tests.txt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@ TestMany2ManyOmitAssociations
2121
TestMany2ManyAssociationForSlice
2222
#TestSingleTableMany2ManyAssociation
2323
#TestSingleTableMany2ManyAssociationForSlice
24-
#TestDuplicateMany2ManyAssociation
24+
TestDuplicateMany2ManyAssociation
2525
TestConcurrentMany2ManyAssociation
26-
#TestMany2ManyDuplicateBelongsToAssociation
26+
TestMany2ManyDuplicateBelongsToAssociation
2727
TestInvalidAssociation
2828
TestAssociationNotNullClear
2929
#TestForeignKeyConstraints
@@ -112,7 +112,7 @@ TestGenericsDelete
112112
TestGenericsFindInBatches
113113
TestGenericsScopes
114114
#TestGenericsJoins
115-
#TestGenericsNestedJoins
115+
TestGenericsNestedJoins
116116
#TestGenericsPreloads
117117
#TestGenericsNestedPreloads
118118
TestGenericsDistinct
@@ -146,7 +146,7 @@ TestJoinCount
146146
#TestInnerJoins
147147
TestJoinWithSameColumnName
148148
#TestJoinArgsWithDB
149-
#TestNestedJoins
149+
TestNestedJoins
150150
TestJoinsPreload_Issue7013
151151
TestJoinsPreload_Issue7013_RelationEmpty
152152
TestJoinsPreload_Issue7013_NoEntries
@@ -267,7 +267,7 @@ TestSubQueryWithHaving
267267
TestQueryWithTableAndConditions
268268
TestQueryWithTableAndConditionsAndAllFields
269269
#TestQueryScannerWithSingleColumn
270-
#TestQueryResetNullValue
270+
TestQueryResetNullValue
271271
TestQueryError
272272
TestQueryScanToArray
273273
TestRownum

0 commit comments

Comments
 (0)