Remove hard coded DB connection values

Author: Harshit-Khasnis

tests/run-tests.sh

@@ -10,9 +10,21 @@
 # 2. Run the script ./run_tests.sh
 
 # Check for required Oracle environment variables
-export GORM_DSN='user="system" password="manager" \
-connectString="phoenix793630.dev3sub1phx.databasede3phx.oraclevcn.com:1661/cdb1_pdb1.regress.rdbms.dev.us.oracle.com" \
-libDir="/home/hkhasnis/projects/pkgs/23IC"'
+missing_vars=()
+for var in GORM_ORACLEDB_USER GORM_ORACLEDB_PASSWORD GORM_ORACLEDB_CONNECTSTRING GORM_ORACLEDB_LIBDIR; do
+    if [ -z "${!var}" ]; then
+        missing_vars+=("$var")
+    fi
+done
+if [ ${#missing_vars[@]} -ne 0 ]; then
+    echo "Error: The following environment variables must be set to run the tests: ${missing_vars[*]}"
+    echo "Example:"
+    echo "  export GORM_ORACLEDB_USER=your_user"
+    echo "  export GORM_ORACLEDB_PASSWORD=your_password"
+    echo "  export GORM_ORACLEDB_CONNECTSTRING=your_connect_string"
+    echo "  export GORM_ORACLEDB_LIBDIR=your_lib_dir"
+    exit 1
+fi
 
 # Check if passed-tests.txt exists
 if [ ! -f "passed-tests.txt" ]; then

tests/tests_test.go

@@ -65,9 +65,32 @@ var newLogger = logger.New(
 	},
 )
 
-var oracleDSN = `user="system" password="manager"
-	connectString="phoenix793630.dev3sub1phx.databasede3phx.oraclevcn.com:1661/cdb1_pdb1.regress.rdbms.dev.us.oracle.com"
-	libDir="/home/hkhasnis/projects/pkgs/23IC"`
+var oracleDSN = func() string {
+	user := os.Getenv("GORM_ORACLEDB_USER")
+	password := os.Getenv("GORM_ORACLEDB_PASSWORD")
+	connectString := os.Getenv("GORM_ORACLEDB_CONNECTSTRING")
+	libDir := os.Getenv("GORM_ORACLEDB_LIBDIR")
+
+	missing := []string{}
+	if user == "" {
+		missing = append(missing, "GORM_ORACLEDB_USER")
+	}
+	if password == "" {
+		missing = append(missing, "GORM_ORACLEDB_PASSWORD")
+	}
+	if connectString == "" {
+		missing = append(missing, "GORM_ORACLEDB_CONNECTSTRING")
+	}
+	if libDir == "" {
+		missing = append(missing, "GORM_ORACLEDB_LIBDIR")
+	}
+	if len(missing) > 0 {
+		log.Fatalf("Missing required environment variables: %v. Please set them to run the tests.", missing)
+	}
+	return `user="` + user + `" password="` + password + `"
+			connectString="` + connectString + `"
+			libDir="` + libDir + `"`
+}()
 
 func init() {
 	var err error