Fix TestCompositePrimaryKeysAssociations

Fix issue by excluding primary keys and default value fields from doUpdate.

Author: Mitika-d

oracle/clause_builder.go

@@ -335,6 +335,34 @@ func OnConflictClauseBuilder(c clause.Clause, builder clause.Builder) {
 				return
 			}
 
+			// exclude primary key, default value columns from merge update clause
+			if len(onConflict.DoUpdates) > 0 {
+				hasPrimaryKey := false
+
+				for _, assignment := range onConflict.DoUpdates {
+					field := stmt.Schema.LookUpField(assignment.Column.Name)
+					if field != nil && field.PrimaryKey {
+						hasPrimaryKey = true
+						break
+					}
+				}
+
+				if hasPrimaryKey {
+					onConflict.DoUpdates = nil
+					columns := make([]string, 0, len(values.Columns)-1)
+					for _, col := range values.Columns {
+						field := stmt.Schema.LookUpField(col.Name)
+
+						if field != nil && !field.PrimaryKey && (!field.HasDefaultValue || field.DefaultValueInterface != nil ||
+							strings.EqualFold(field.DefaultValue, "NULL")) && field.AutoCreateTime == 0 {
+							columns = append(columns, col.Name)
+						}
+
+					}
+					onConflict.DoUpdates = append(onConflict.DoUpdates, clause.AssignmentColumns(columns)...)
+				}
+			}
+
 			// Build MERGE statement
 			buildMergeInClause(stmt, onConflict, values, conflictColumns)
 		}

tests/multi_primary_keys_test.go

@@ -454,8 +454,6 @@ func TestManyToManyWithCustomizedForeignKeys2(t *testing.T) {
 }
 
 func TestCompositePrimaryKeysAssociations(t *testing.T) {
-	t.Skip()
-
 	type Label struct {
 		BookID *uint  `gorm:"primarykey"`
 		Name   string `gorm:"primarykey"`

tests/passed-tests.txt

@@ -192,7 +192,7 @@ TestMigrateExistingBoolColumnPG
 #TestManyToManyWithMultiPrimaryKeys
 #TestManyToManyWithCustomizedForeignKeys
 #TestManyToManyWithCustomizedForeignKeys2
-#TestCompositePrimaryKeysAssociations
+TestCompositePrimaryKeysAssociations
 TestNamedArg
 TestNamedArgMultipleSameParamRefs
 TestNamedArgNullValues