Skip to content

Commit b60e455

Browse files
authored
Reversed 1.04 and and 1.0.5 (#10)
* reversed 1.0.4 and 1.0.5 * doc changes and tenancy in ons
1 parent ff5e3fa commit b60e455

File tree

5 files changed

+11
-10
lines changed

5 files changed

+11
-10
lines changed

CHANGELOG.adoc

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,9 @@ All notable changes to this project are documented in this file.
77

88
The format is based on {uri-changelog}[Keep a Changelog].
99

10+
= v1.0.6 (August 31,2020)
11+
* Reversed 1.0.4 and 1.0.5 (#9)
12+
1013
== v1.0.5 (August 5,2020)
1114
* tenancy id is needed for list of ADs (#7)
1215

datasources.tf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
# Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl/
33

44
data "oci_identity_availability_domains" "ad_list" {
5-
compartment_id = var.root_compartment_id
5+
compartment_id = var.tenancy_id
66
}
77

88
data "template_file" "ad_names" {
@@ -11,7 +11,7 @@ data "template_file" "ad_names" {
1111
}
1212

1313
data "oci_identity_tenancy" "tenancy" {
14-
tenancy_id = var.root_compartment_id
14+
tenancy_id = var.tenancy_id
1515
}
1616

1717
# get the tenancy's home region

docs/terraformoptions.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ Ensure you review the {uri-terraform-dependencies}[dependencies].
196196
|bastion
197197
|===
198198

199-
== Taggin Parameters
199+
== Tagging Parameters
200200

201201
[stripes=odd,cols="1d,4d,3a,3a", options=header,width="100%"]
202202
|===

ons.tf

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,11 @@
33

44
provider "oci" {
55
alias = "home"
6+
fingerprint = var.api_fingerprint
7+
private_key_path = var.api_private_key_path
68
region = lookup(data.oci_identity_regions.home_region.regions[0], "name")
9+
tenancy_ocid = var.tenancy_id
10+
user_ocid = var.user_id
711
}
812

913
resource "oci_ons_notification_topic" "bastion_notification" {
@@ -25,7 +29,7 @@ resource "oci_ons_subscription" "bastion_notification" {
2529
resource "oci_identity_dynamic_group" "bastion_notification" {
2630
provider = oci.home
2731

28-
compartment_id = var.root_compartment_id
32+
compartment_id = var.tenancy_id
2933
depends_on = [oci_core_instance.bastion]
3034
description = "dynamic group to allow bastion to send notifications to ONS"
3135
matching_rule = "ALL {instance.id = '${join(",", data.oci_core_instance.bastion.*.id)}'}"

variables.tf

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -45,12 +45,6 @@ variable "label_prefix" {
4545
default = "none"
4646
}
4747

48-
variable "root_compartment_id" {
49-
# specify a different name so it can be used in resource manager
50-
description = "tenancy id where to create the sources"
51-
type = string
52-
}
53-
5448
# network parameters
5549

5650
variable "availability_domain" {

0 commit comments

Comments
 (0)