Skip to content

Commit de6d2bb

Browse files
committed
feat: Support disabled DNS record assignment for bastion subnet
Signed-off-by: Devon Crouse <[email protected]>
1 parent 6317065 commit de6d2bb

File tree

3 files changed

+24
-3
lines changed

3 files changed

+24
-3
lines changed

CHANGELOG.adoc

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,21 @@ All notable changes to this project are documented in this file.
77

88
The format is based on {uri-changelog}[Keep a Changelog].
99

10+
= v3.1.4 (unreleased)
11+
* feat: Support disabled DNS record assignment for bastion subnet by @devoncrouse
12+
13+
= v3.1.3 (October 7, 2022)
14+
* fix: Ignore lifecycle changes, and use consistent fallback shape by @devoncrouse in #51
15+
16+
= v3.1.2 (October 5, 2022)
17+
* fix: Compartment AD listing, ignore lifecycle changes by @devoncrouse in #50
18+
19+
= v3.1.1 (April 26, 2022)
20+
* fix: made autonomous cloud init template optional. by @hyder in #49
21+
22+
= v3.1.0 (March 27, 2022)
23+
* fix: Provider changed from hashicorp/oci to oracle/oci by @karthicgit in #47
24+
1025
= v3.0.0 (September 21, 2021)
1126

1227
== New features

subnets.tf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
1-
# Copyright 2019, 2021 Oracle Corporation and/or affiliates. All rights reserved.
1+
# Copyright 2019, 2022 Oracle Corporation and/or affiliates. All rights reserved.
22
# Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl/
33

44
resource "oci_core_subnet" "bastion" {
55
cidr_block = cidrsubnet(local.vcn_cidr, var.newbits, var.netnum)
66
compartment_id = var.compartment_id
77
display_name = var.label_prefix == "none" ? "bastion" : "${var.label_prefix}-bastion"
8-
dns_label = "bastion"
8+
dns_label = var.assign_dns ? "bastion" : null
99
freeform_tags = var.freeform_tags
1010
prohibit_public_ip_on_vnic = var.bastion_type == "public" ? false : true
1111
route_table_id = var.ig_route_id

variables.tf

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Copyright (c) 2019, 2021 Oracle Corporation and/or affiliates. All rights reserved.
1+
# Copyright (c) 2019, 2022 Oracle Corporation and/or affiliates. All rights reserved.
22
# Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl
33

44
# provider parameters
@@ -20,6 +20,12 @@ variable "label_prefix" {
2020
default = "none"
2121
}
2222

23+
variable "assign_dns" {
24+
default = true
25+
description = "Whether to assign DNS records to created instances"
26+
type = bool
27+
}
28+
2329
# network parameters
2430
variable "availability_domain" {
2531
description = "the AD to place the bastion host"

0 commit comments

Comments
 (0)