feat: Reflect platform_config type from worker shape

Signed-off-by: Devon Crouse <[email protected]>

Author: devoncrouse

examples/vars-workers-advanced.auto.tfvars

@@ -45,9 +45,8 @@ worker_pools = {
   },
   shielded_instances = {
     description = "Self-managed Shielded VM Instance", create = false,
-    size = 1, mode = "instance", shape = "VM.Standard2.4",
+    size        = 1, mode = "instance", shape = "VM.Standard2.4",
     platform_config = {
-      type                               = "INTEL_VM",
       is_measured_boot_enabled           = true,
       is_secure_boot_enabled             = true,
       is_trusted_platform_module_enabled = true,

modules/workers/data-shapes.tf

@@ -0,0 +1,18 @@
+# Copyright (c) 2023 Oracle Corporation and/or its affiliates.
+# Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl
+
+data "oci_core_shapes" "oke" {
+  compartment_id = var.compartment_id
+}
+
+locals {
+  shapes_by_name = {
+    for shape in data.oci_core_shapes.oke.shapes :
+    lookup(shape, "name") => shape if contains(keys(shape), "name")
+  }
+
+  platform_config_by_shape = {
+    for k, v in local.shapes_by_name :
+    k => merge(lookup(v, "platform_config_options", [])...)
+  }
+}

modules/workers/instance.tf

@@ -22,7 +22,13 @@ resource "oci_core_instance" "workers" {
   dynamic "platform_config" {
     for_each = each.value.platform_config != null ? [1] : []
     content {
-      type                                           = lookup(each.value.platform_config, "type")
+      type = lookup(
+        # Attempt lookup against data source for the associated 'type' of configured worker shape
+        lookup(local.platform_config_by_shape, each.value.shape, {}), "type",
+        # Fall back to 'type' on pool with custom platform_config, or INTEL_VM default
+        lookup(each.value.platform_config, "type", "INTEL_VM")
+      )
+      # Remaining parameters as configured, validated by instance/instance config resource
       are_virtual_instructions_enabled               = lookup(each.value.platform_config, "are_virtual_instructions_enabled", null)
       is_access_control_service_enabled              = lookup(each.value.platform_config, "is_access_control_service_enabled", null)
       is_input_output_memory_management_unit_enabled = lookup(each.value.platform_config, "is_input_output_memory_management_unit_enabled", null)

modules/workers/instanceconfig.tf

@@ -67,7 +67,13 @@ resource "oci_core_instance_configuration" "workers" {
       dynamic "platform_config" {
         for_each = each.value.platform_config != null ? [1] : []
         content {
-          type                                           = lookup(each.value.platform_config, "type")
+          type = lookup(
+            # Attempt lookup against data source for the associated 'type' of configured worker shape
+            lookup(local.platform_config_by_shape, each.value.shape, {}), "type",
+            # Fall back to 'type' on pool with custom platform_config, or INTEL_VM default
+            lookup(each.value.platform_config, "type", "INTEL_VM")
+          )
+          # Remaining parameters as configured, validated by instance/instance config resource
           are_virtual_instructions_enabled               = lookup(each.value.platform_config, "are_virtual_instructions_enabled", null)
           is_access_control_service_enabled              = lookup(each.value.platform_config, "is_access_control_service_enabled", null)
           is_input_output_memory_management_unit_enabled = lookup(each.value.platform_config, "is_input_output_memory_management_unit_enabled", null)

variables-workers.tf

@@ -235,7 +235,7 @@ variable "platform_config" {
   default     = null
   description = "Default platform_config for self-managed worker pools created with mode: 'instance', 'instance-pool', or 'cluster-network'. See <a href=https://docs.oracle.com/en-us/iaas/api/#/en/iaas/20160918/datatypes/PlatformConfig>PlatformConfig</a> for more information."
   type = object({
-    type                                           = string,
+    type                                           = optional(string),
     are_virtual_instructions_enabled               = optional(bool),
     is_access_control_service_enabled              = optional(bool),
     is_input_output_memory_management_unit_enabled = optional(bool),