fix: add preferred_loadbalancer validation (#627)

und3f · web-flow · commit 9561e1ac7046 · 2023-01-11T11:12:03.000+11:00
fix: add preffered_loadblancer validation
diff --git a/modules/oke/cluster.tf b/modules/oke/cluster.tf
@@ -71,11 +71,16 @@ resource "oci_containerengine_cluster" "k8s_cluster" {
       defined_tags  = lookup(var.defined_tags,"service_lb",{})
     }
 
-    service_lb_subnet_ids = var.preferred_load_balancer == "public" ? [var.cluster_subnets["pub_lb"]] : [var.cluster_subnets["int_lb"]]
+    service_lb_subnet_ids = [var.cluster_subnets[local.lb_subnet]]
   }
 
   lifecycle {
     ignore_changes = [defined_tags, freeform_tags, cluster_pod_network_options]
+
+    precondition {
+      condition     = var.cluster_subnets[local.lb_subnet] != ""
+      error_message = "Preferred load balancer references unexisting load balancer. Please check variables preferred_load_balancer and load_balancers."
+    }
   }
 
   vcn_id = var.vcn_id

Original file line number	Diff line number	Diff line change
`@@ -71,11 +71,16 @@ resource "oci_containerengine_cluster" "k8s_cluster" {`
`71`	`71`	`defined_tags = lookup(var.defined_tags,"service_lb",{})`
`72`	`72`	`}`
`73`	`73`
`74`		`- service_lb_subnet_ids = var.preferred_load_balancer == "public" ? [var.cluster_subnets["pub_lb"]] : [var.cluster_subnets["int_lb"]]`
	`74`	`+ service_lb_subnet_ids = [var.cluster_subnets[local.lb_subnet]]`
`75`	`75`	`}`
`76`	`76`
`77`	`77`	`lifecycle {`
`78`	`78`	`ignore_changes = [defined_tags, freeform_tags, cluster_pod_network_options]`
	`79`	`+`
	`80`	`+ precondition {`
	`81`	`+ condition = var.cluster_subnets[local.lb_subnet] != ""`
	`82`	`+ error_message = "Preferred load balancer references unexisting load balancer. Please check variables preferred_load_balancer and load_balancers."`
	`83`	`+ }`
`79`	`84`	`}`
`80`	`85`
`81`	`86`	`vcn_id = var.vcn_id`