Skip to content

Commit b7edce2

Browse files
committed
Merge branch 'sauraahu-130-issue-fixes'
2 parents 9007667 + ec1c218 commit b7edce2

File tree

6 files changed

+119
-31
lines changed

6 files changed

+119
-31
lines changed

CHANGELOG.adoc

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,15 @@ All notable changes to this project are documented in this file.
77

88
The format is based on {uri-changelog}[Keep a Changelog].
99

10+
== 2.1.4 (March 31, 2020)
11+
* removed provider.tf so module can be used from hashicorp registry, added instructions for using this repo and hashicorp module (#130)
12+
* fixed incorrect part about bastion host and tools in topology (#141)
13+
* upgraded default helm version on admin host to 3.1.1 (#134)
14+
15+
== 2.1.3 (March 6, 2020)
16+
* fixed broken links in README.md (#132)
17+
* updated documentation in topology to use netnum instead of previous variable name
18+
1019
== 2.1.2 (February 19, 2020)
1120
* base module now points to the published base module on hashicorp registry
1221
* updated descriptions in variables, outputs and formatting to publish to hashicorp registry

docs/quickstart.adoc

Lines changed: 108 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@
1616
:uri-terraform: https://www.terraform.io
1717
:uri-terraform-oci: https://www.terraform.io/docs/providers/oci/index.html
1818
:uri-terraform-options: {uri-docs}/terraformoptions.adoc
19+
:uri-topology: {uri-docs}/topology.adoc
20+
:uri-variables: {uri-rel-file-base}/variables.tf
1921

2022
. link:#assumptions[Assumptions]
2123
. link:#pre-requisites[Pre-requisites]
@@ -32,12 +34,13 @@
3234

3335
1. git is installed
3436
2. ssh client is installed
35-
3. Terraform 0.12.4+ is installed
37+
3. Terraform 0.12.16+ is installed
3638

37-
=== Instructions
39+
=== Provisioning using this git repo
3840

39-
1. Clone the repo:
41+
. Clone the repo:
4042

43+
+
4144
[source,bash]
4245
----
4346
git clone https://github.com/oracle-terraform-modules/terraform-oci-oke.git tfoke
@@ -46,7 +49,21 @@ cd tfoke
4649
cp terraform.tfvars.example terraform.tfvars
4750
----
4851

49-
2. Set mandatory parameters:
52+
. Create a provider.tf file and add the following:
53+
54+
+
55+
----
56+
provider "oci" {
57+
tenancy_ocid = var.tenancy_id
58+
user_ocid = var.user_id
59+
fingerprint = var.api_fingerprint
60+
private_key_path = var.api_private_key_path
61+
region = var.region
62+
disable_auto_retries = var.disable_auto_retries
63+
}
64+
----
65+
66+
. Set mandatory parameters:
5067

5168
* api_fingerprint
5269
* api_private_key_path
@@ -55,19 +72,100 @@ cp terraform.tfvars.example terraform.tfvars
5572
* tenancy_id
5673
* user_id
5774

58-
3. Override other parameters:
75+
. Override other parameters:
5976

6077
* region
6178

62-
4. Optional parameters to override:
63-
* ssh_private_key_path
64-
* ssh_public_key_path
65-
* vcn_dns_label
66-
* vcn_name
79+
. Optional parameters to override:
6780
* bastion_enabled
6881
* cluster_name
82+
* ssh_private_key_path (Required if bastion is enabled)
83+
* ssh_public_key_path (Required if bastion is enabled)
84+
* vcn_dns_label
85+
* vcn_name
6986
* worker_mode
7087

88+
. Run Terraform:
89+
90+
+
91+
[source,bash]
92+
----
93+
terraform init
94+
terraform plan
95+
terraform apply
96+
----
97+
98+
=== Provisioning using the Hashicorp registry module
99+
100+
. In your project root, create a provider.tf file and add the following:
101+
102+
+
103+
----
104+
provider "oci" {
105+
tenancy_ocid = var.tenancy_id
106+
user_ocid = var.user_id
107+
fingerprint = var.api_fingerprint
108+
private_key_path = var.api_private_key_path
109+
region = var.region
110+
disable_auto_retries = var.disable_auto_retries
111+
}
112+
----
113+
114+
. In your project root, create a variables.tf file and add variables for your project. You can copy the existing {uri-variables}[variables.tf] in the oke module root.
115+
116+
. In your project root, create a main.tf file and add the following:
117+
118+
+
119+
----
120+
module "oke" {
121+
source = "oracle-terraform-modules/oke/oci"
122+
version = "2.1.3"
123+
# insert the 23 required variables here
124+
}
125+
----
126+
127+
. Edit your oke module definition and pass the required variables:
128+
129+
+
130+
----
131+
module "oke" {
132+
source = "oracle-terraform-modules/oke/oci"
133+
version = "2.1.3"
134+
135+
compartment_id = var.compartment_id
136+
tenancy_id = var.tenancy_id
137+
user_id = var.user_id
138+
139+
ssh_private_key_path = var.ssh_private_key_path
140+
ssh_public_key_path = var.ssh_public_key_path
141+
142+
label_prefix = var.label_prefix
143+
region = var.region
144+
145+
vcn_dns_label = var.vcn_dns_label
146+
vcn_name = var.vcn_name
147+
148+
bastion_shape = var.bastion_shape
149+
bastion_timezone = var.bastion_timezone
150+
151+
admin_shape = var.admin_shape
152+
admin_timezone = var.admin_timezone
153+
154+
# add additional parameters for availability_domains, oke etc as you need
155+
156+
}
157+
----
158+
159+
. Run Terraform:
160+
161+
+
162+
[source,bash]
163+
----
164+
terraform init
165+
terraform plan
166+
terraform apply
167+
----
168+
71169
=== Related documentation:
72170

73171
* {uri-instructions}[Detailed Instructions]

docs/topology.adoc

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -134,14 +134,6 @@ To ssh to the worker nodes, you can do the following:
134134
ssh -i /path/to/private_key -J <username>@bastion_ip opc@worker_node_private_ip
135135
----
136136

137-
When the bastion host is created, the following are pre-installed and configured:
138-
139-
* git, kubectl, helm, oci-cli
140-
* default KUBECONFIG location (~/.kube/config)
141-
* aliases kubectl (k), helm (h), oci-cli (oci)
142-
143-
Although oci-cli is pre-installed, it is *_not_* configured. Read more about {uri-oci-configure-cli}[configuring the oci-cli].
144-
145137
=== Public vs Private worker nodes
146138

147139
.Public Worker Nodes

provider.tf

Lines changed: 0 additions & 11 deletions
This file was deleted.

terraform.tfvars.example

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ bastion_enabled = true
5555

5656
bastion_image_id = "Autonomous"
5757

58-
bastion_notification_enabled = true
58+
bastion_notification_enabled = false
5959

6060
bastion_notification_endpoint = "<email_address>"
6161

variables.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -380,7 +380,7 @@ variable "username" {
380380
# helm
381381
variable "helm_version" {
382382
description = "version of helm to install"
383-
default = "3.0.0"
383+
default = "3.1.1"
384384
type = string
385385
}
386386

0 commit comments

Comments
 (0)