Skip to content

Commit e2ffd31

Browse files
authored
changed nodepools image specs from node_image_id to node_source_details. added new ocir urls (#125)
1 parent 7b57ce4 commit e2ffd31

File tree

3 files changed

+18
-4
lines changed

3 files changed

+18
-4
lines changed

CHANGELOG.adoc

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,17 @@ All notable changes to this project are documented in this file.
77

88
The format is based on {uri-changelog}[Keep a Changelog].
99

10-
== v2.1.0 (January 17, 2019)
10+
== 2.1.1 (February 06, 2020)
11+
* Install latest version of kubectl into admin host (#119)
12+
* Added OCIR support for new regions (#122)
13+
* Changed nodepools image specs from node_image_id to node_source_details (#124)
14+
15+
== v2.1.0 (January 17, 2020)
1116
* Base module now pointing directly to https://github.com/oracle-terraform-modules/terraform-oci-base v1.1.0
1217
* Local copy of base module removed
1318
* Disabled Kubernetes dashboard by default (#117)
1419

15-
== v2.0.1 (January 16, 2019)
20+
== v2.0.1 (January 16, 2020)
1621
* fixed issue with compartment id when using KMS #112
1722
* added ServiceAccount for CI/CD #113
1823

modules/oke/nodepools.tf

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,12 @@ resource "oci_containerengine_node_pool" "nodepools" {
2323
size = max(3, element(var.node_pools.node_pools[(element(keys(var.node_pools.node_pools), count.index))], 1))
2424
}
2525

26-
node_image_id = var.node_pools.node_pool_image_id == "NONE" ? data.oci_core_images.latest_images[count.index].images[0].id : var.node_pools.node_pool_image_id
26+
node_source_details {
27+
image_id = var.node_pools.node_pool_image_id == "NONE" ? data.oci_core_images.latest_images[count.index].images[0].id : var.node_pools.node_pool_image_id
28+
source_type = "IMAGE"
29+
}
30+
31+
# node_image_id = var.node_pools.node_pool_image_id == "NONE" ? data.oci_core_images.latest_images[count.index].images[0].id : var.node_pools.node_pool_image_id
2732
node_shape = element(var.node_pools.node_pools[(element(keys(var.node_pools.node_pools), count.index))], 0)
2833

2934
ssh_public_key = file(var.oke_ssh_keys.ssh_public_key_path)

variables.tf

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -359,12 +359,16 @@ variable "ocir_urls" {
359359
description = "urls of ocir"
360360
default = {
361361
ap-sydney-1 = "syd.ocir.io"
362+
ap-melbourne-1 = "mel.ocir.io"
362363
ap-mumbai-1 = "bom.ocir.io"
364+
ap-osaka-1 = "kix.ocir.io"
363365
ap-seoul-1 = "icn.ocir.io"
364366
ap-tokyo-1 = "nrt.ocir.io"
365367
ca-toronto-1 = "yyz.ocir.io"
368+
eu-amsterdam-1 = "ams.ocir.io"
366369
eu-frankfurt-1 = "fra.ocir.io"
367370
eu-zurich-1 = "zrh.ocir.io"
371+
me-jeddah-1 = "jed.ocir.io"
368372
sa-saopaulo-1 = "gru.ocir.io"
369373
uk-london-1 = "lhr.ocir.io"
370374
us-ashburn-1 = "iad.ocir.io"
@@ -473,4 +477,4 @@ variable "service_account_cluster_role_binding" {
473477
description = "cluster role binding name"
474478
default = ""
475479
type = string
476-
}
480+
}

0 commit comments

Comments
 (0)