Handle machine deletion when NLB/LB has been deleted (#350)

* Handle machine deletion when NLB/LB has been deleted

Author: shyamradhakrishnan

cloud/scope/machine.go

@@ -616,6 +616,10 @@ func (m *MachineScope) ReconcileDeleteInstanceOnLB(ctx context.Context) error {
 			LoadBalancerId: loadbalancerId,
 		})
 		if err != nil {
+			if ociutil.IsNotFound(err) {
+				m.Logger.Info("LB has been deleted", "lb", *loadbalancerId)
+				return nil
+			}
 			return err
 		}
 		backendSet := lb.BackendSets[APIServerLBBackendSetName]
@@ -665,6 +669,10 @@ func (m *MachineScope) ReconcileDeleteInstanceOnLB(ctx context.Context) error {
 			NetworkLoadBalancerId: loadbalancerId,
 		})
 		if err != nil {
+			if ociutil.IsNotFound(err) {
+				m.Logger.Info("NLB has been deleted", "nlb", *loadbalancerId)
+				return nil
+			}
 			return err
 		}
 		backendSet := lb.BackendSets[APIServerLBBackendSetName]

cloud/scope/machine_test.go

@@ -1636,6 +1636,16 @@ func TestNLBReconciliationDeletion(t *testing.T) {
 					NetworkLoadBalancer: networkloadbalancer.NetworkLoadBalancer{}}, errors.New("could not get nlb"))
 			},
 		},
+		{
+			name:          "get nlb error, not found",
+			errorExpected: false,
+			testSpecificSetup: func(machineScope *MachineScope, nlbClient *mock_nlb.MockNetworkLoadBalancerClient) {
+				nlbClient.EXPECT().GetNetworkLoadBalancer(gomock.Any(), gomock.Eq(networkloadbalancer.GetNetworkLoadBalancerRequest{
+					NetworkLoadBalancerId: common.String("nlbid"),
+				})).Return(networkloadbalancer.GetNetworkLoadBalancerResponse{
+					NetworkLoadBalancer: networkloadbalancer.NetworkLoadBalancer{}}, ociutil.ErrNotFound)
+			},
+		},
 		{
 			name:          "backend exists",
 			errorExpected: false,
@@ -2178,6 +2188,22 @@ func TestLBReconciliationDeletion(t *testing.T) {
 		errorSubStringMatch bool
 		testSpecificSetup   func(machineScope *MachineScope, lbClient *mock_lb.MockLoadBalancerClient)
 	}{
+		{
+			name:          "get lb error",
+			errorExpected: false,
+			testSpecificSetup: func(machineScope *MachineScope, nlbClient *mock_lb.MockLoadBalancerClient) {
+				machineScope.OCIMachine.Status.Addresses = []clusterv1.MachineAddress{
+					{
+						Type:    clusterv1.MachineInternalIP,
+						Address: "1.1.1.1",
+					},
+				}
+				nlbClient.EXPECT().GetLoadBalancer(gomock.Any(), gomock.Eq(loadbalancer.GetLoadBalancerRequest{
+					LoadBalancerId: common.String("lbid"),
+				})).Return(loadbalancer.GetLoadBalancerResponse{
+					LoadBalancer: loadbalancer.LoadBalancer{}}, ociutil.ErrNotFound)
+			},
+		},
 		{
 			name:          "get lb error",
 			errorExpected: true,