fix: Dereferencing on nil pointers panic fix (#446)

* fixed SeclistID nil pointer deference

* Fixed some panics on nil pointer deference

* modified test with correct error string

Author: alcampag

cloud/scope/managed_machine_pool.go

@@ -28,6 +28,7 @@ import (
 	"github.com/go-logr/logr"
 	infrastructurev1beta2 "github.com/oracle/cluster-api-provider-oci/api/v1beta2"
 	"github.com/oracle/cluster-api-provider-oci/cloud/ociutil"
+	"github.com/oracle/cluster-api-provider-oci/cloud/ociutil/ptr"
 	"github.com/oracle/cluster-api-provider-oci/cloud/services/computemanagement"
 	"github.com/oracle/cluster-api-provider-oci/cloud/services/containerengine"
 	expinfra1 "github.com/oracle/cluster-api-provider-oci/exp/api/v1beta2"
@@ -555,8 +556,8 @@ func (m *ManagedMachinePoolScope) buildPlacementConfig(configs []expinfra1.Place
 	for _, config := range configs {
 		subnetId := m.getWorkerMachineSubnet(config.SubnetName)
 		if subnetId == nil {
-			return nil, errors.New(fmt.Sprintf("worker subnet with name %s is not present in spec",
-				*config.SubnetName))
+			return nil, errors.New(fmt.Sprintf("worker subnet %s is not present in placementConfigs spec",
+				ptr.ToString(config.SubnetName)))
 		}
 		placementConfigs = append(placementConfigs, oke.NodePoolPlacementConfigDetails{
 			AvailabilityDomain:    config.AvailabilityDomain,
@@ -581,7 +582,7 @@ func (m *ManagedMachinePoolScope) getInitialNodeKeyValuePairs() []oke.KeyValue {
 
 func (m *ManagedMachinePoolScope) getWorkerMachineSubnet(name *string) *string {
 	for _, subnet := range m.OCIManagedCluster.Spec.NetworkSpec.Vcn.Subnets {
-		if subnet != nil && subnet.ID != nil && subnet.Name == *name {
+		if subnet != nil && subnet.ID != nil && subnet.Name == ptr.ToString(name) {
 			return subnet.ID
 		}
 	}

cloud/scope/managed_machine_pool_test.go

@@ -789,7 +789,7 @@ func TestManagedMachinePoolCreate(t *testing.T) {
 		{
 			name:          "nodepool no worker subnets",
 			errorExpected: true,
-			matchError: errors.New(fmt.Sprintf("worker subnet with name %s is not present in spec",
+			matchError: errors.New(fmt.Sprintf("worker subnet %s is not present in placementConfigs spec",
 				"worker-subnet-invalid")),
 			testSpecificSetup: func(cs *ManagedMachinePoolScope, okeClient *mock_containerengine.MockClient) {
 				ms.OCIManagedCluster.Spec.OCIResourceIdentifier = "resource_uid"

cloud/scope/subnet_reconciler.go

@@ -175,6 +175,11 @@ func (s *ClusterScope) UpdateSubnet(ctx context.Context, spec infrastructurev1be
 		CidrBlock:   common.String(spec.CIDR),
 	}
 	if spec.SecurityList != nil {
+		if spec.SecurityList.ID == nil {
+			err := errors.New("SecurityListID required")
+			s.Logger.Error(err, "failed updating subnet")
+			return err
+		}
 		updateSubnetDetails.SecurityListIds = []string{*spec.SecurityList.ID}
 	}
 	subnetResponse, err := s.VCNClient.UpdateSubnet(ctx, core.UpdateSubnetRequest{
@@ -297,10 +302,13 @@ func (s *ClusterScope) IsSubnetsEqual(actual *core.Subnet, desired infrastructur
 	if desired.CIDR != *actual.CidrBlock {
 		return false
 	}
-	if desired.SecurityList != nil {
-		if *desired.SecurityList.ID != actual.SecurityListIds[0] {
-			return false
+	if desired.SecurityList != nil && desired.SecurityList.ID != nil {
+		for _, securityListId := range actual.SecurityListIds {
+			if *desired.SecurityList.ID == securityListId {
+				return true
+			}
 		}
+		return false
 	}
 	return true
 }