Add more CLI tests

Author: thegridman

java/coherence-operator/src/main/java/com/oracle/coherence/k8s/CoherenceOperatorLifecycleListener.java

@@ -305,6 +305,17 @@ && tryCreateConfig(new File(cohCtlHome), connectionType, protocol, port, cluster
             if (fileUserHome.exists() && fileUserHome.isDirectory()) {
                 // use ${user.home}/.cohctl
                 fileCohCtlHome = new File(fileUserHome, ".cohctl");
+                if (!fileCohCtlHome.exists()) {
+                    try {
+                        if (!fileCohCtlHome.mkdirs()) {
+                            fileCohCtlHome = null;
+                        }
+                    }
+                    catch (Exception e) {
+                        LOGGER.error("CoherenceOperator: Failed to create cohctl home directory at " + fileCohCtlHome, e);
+                        fileCohCtlHome = null;
+                    }
+                }
             }
 
             boolean success = false;

test/e2e/local/cli_test.go

@@ -35,3 +35,30 @@ func TestCoherenceCLI(t *testing.T) {
 	t.Log(string(out))
 	g.Expect(err).NotTo(HaveOccurred())
 }
+
+// Test that the Coherence CLI can be executed in a Pod
+func TestCoherenceCLIWithCustomHome(t *testing.T) {
+	// Make sure we defer clean-up when we're done!!
+	testContext.CleanupAfterTest(t)
+	g := NewWithT(t)
+
+	deployments, _ := helper.AssertDeployments(testContext, t, "deployment-cli-home.yaml")
+
+	data, ok := deployments["storage"]
+	g.Expect(ok).To(BeTrue(), "did not find expected 'storage' deployment")
+
+	hasFinalizer := controllerutil.ContainsFinalizer(&data, coh.CoherenceFinalizer)
+	g.Expect(hasFinalizer).To(BeTrue())
+
+	out, err := exec.Command("kubectl", "-n", data.Namespace, "exec", "storage-0",
+		"-c", "coherence", "--", "/coherence-operator/utils/cohctl", "get", "members").CombinedOutput()
+	t.Log("CLI Output:")
+	t.Log(string(out))
+	g.Expect(err).NotTo(HaveOccurred())
+
+	out, err = exec.Command("kubectl", "-n", data.Namespace, "exec", "storage-0",
+		"-c", "coherence", "--", "/coherence-operator/utils/cohctl", "--config-dir", "/test/cli", "get", "members").CombinedOutput()
+	t.Log("CLI Output:")
+	t.Log(string(out))
+	g.Expect(err).NotTo(HaveOccurred())
+}

test/e2e/local/deployment-cli-home.yaml

@@ -0,0 +1,21 @@
+apiVersion: coherence.oracle.com/v1
+kind: Coherence
+metadata:
+  name: storage
+spec:
+  env:
+    - name: COH_SKIP_SITE
+      value: "true"
+    - name: COHCTL_HOME
+      value: /test/cli
+  volumeMounts:
+    - mountPath: /test/cli
+      name: cli
+      readOnly: false
+  volumes:
+    - name: cli
+      emptyDir: {}
+
+
+
+