Skip to content

Commit 8308bd6

Browse files
committed
Changes to compatibility tests
1 parent 2adcf1d commit 8308bd6

File tree

4 files changed

+15
-5
lines changed

4 files changed

+15
-5
lines changed

.github/workflows/compatibility-tests.yaml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,14 @@ jobs:
7676
kubectl version
7777
kubectl get nodes
7878
docker pull gcr.io/distroless/java
79+
docker pull ghcr.io/oracle/coherence-operator:3.0.2
80+
docker tag ghcr.io/oracle/coherence-operator:3.0.2 container-registry.oracle.com/middleware/coherence-operator:3.0.2
81+
kind load docker-image --name operator container-registry.oracle.com/middleware/coherence-operator:3.0.2
82+
docker pull ghcr.io/oracle/coherence-operator:3.0.2-utils
83+
docker tag ghcr.io/oracle/coherence-operator:3.0.2-utils container-registry.oracle.com/middleware/coherence-operator:3.0.2-utils
84+
kind load docker-image --name operator container-registry.oracle.com/middleware/coherence-operator:3.0.2-utils
85+
docker pull oraclecoherence/coherence-ce:14.1.1-0-1
86+
kind load docker-image --name operator oraclecoherence/coherence-ce:14.1.1-0-1
7987
8088
- name: Code Review
8189
shell: bash

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -474,7 +474,7 @@ compatibility-test: export OPERATOR_IMAGE := $(OPERATOR_IMAGE)
474474
compatibility-test: export COHERENCE_IMAGE := $(COHERENCE_IMAGE)
475475
compatibility-test: export UTILS_IMAGE := $(UTILS_IMAGE)
476476
compatibility-test: export GO_TEST_FLAGS_E2E := $(strip $(GO_TEST_FLAGS_E2E))
477-
compatibility-test: $(BUILD_TARGETS)/build-operator undeploy clean-namespace reset-namespace gotestsum
477+
compatibility-test: undeploy build-all-images $(BUILD_HELM)/coherence-operator-$(VERSION).tgz undeploy clean-namespace reset-namespace gotestsum
478478
helm repo add coherence https://oracle.github.io/coherence-operator/charts
479479
helm repo update
480480
$(GOTESTSUM) --format standard-verbose --junitfile $(TEST_LOGS_DIR)/operator-e2e-compatibility-test.xml \

helm-charts/coherence-operator/templates/deployment.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ apiVersion: v1
1111
kind: Service
1212
metadata:
1313
labels:
14+
name: coherence-operator
1415
control-plane: coherence
1516
name: coherence-operator-webhook-service
1617
namespace: {{ .Release.Namespace }}

test/e2e/compatibility/compatibility_test.go

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ func TestCompatibility(t *testing.T) {
2424

2525
ns := helper.GetTestNamespace()
2626
name := "operator"
27-
defer CleanupBlind(ns, name)
27+
defer CleanupBlind(t, ns, name)
2828

2929
version := os.Getenv("COMPATIBLE_VERSION")
3030
g.Expect(version).NotTo(BeEmpty(), "COMPATIBLE_VERSION environment variable has not been set")
@@ -104,11 +104,12 @@ func InstallCurrentVersion(g *GomegaWithT, ns, name string) {
104104
g.Expect(len(pods)).To(Equal(1))
105105
}
106106

107-
func CleanupBlind(namespace, name string) {
108-
_ = Cleanup(namespace, name)
107+
func CleanupBlind(t *testing.T, namespace, name string) {
108+
_ = Cleanup(t, namespace, name)
109109
}
110110

111-
func Cleanup(namespace, name string) error {
111+
func Cleanup(t *testing.T, namespace, name string) error {
112+
helper.DumpOperatorLogs(t, testContext)
112113
_ = helper.WaitForCoherenceCleanup(testContext, namespace)
113114
return UninstallOperator(namespace, name)
114115
}

0 commit comments

Comments
 (0)