Fix code review issues

Author: thegridman

.gitignore

@@ -39,3 +39,4 @@ test/**/test-report.xml
 
 # Generated file created by the build
 /pkg/data/zz_generated_assets.go
+/__debug_bin

api/v1/coherence_webhook.go

@@ -54,7 +54,7 @@ func (in *Coherence) Default() {
 		in.Spec.EnsureCoherenceUtilsImage(&utilsImage)
 
 		// Set the features supported by this version
-		in.Annotations[ANNOTATION_FEATURE_SUSPEND] = "true"
+		in.Annotations[AnnotationFeatureSuspend] = "true"
 	} else {
 		logger.Info("skipping defaulting for existing resource")
 	}

api/v1/coherenceresourcespec_types.go

@@ -773,7 +773,7 @@ func (in *CoherenceResourceSpec) CreateDefaultEnv(deployment *Coherence) []corev
 		corev1.EnvVar{Name: EnvVarCohHealthPort, Value: Int32ToString(in.GetHealthPort())},
 	)
 
-	if deployment.Annotations[ANNOTATION_FEATURE_SUSPEND] == "true" {
+	if deployment.Annotations[AnnotationFeatureSuspend] == "true" {
 		env = append(env, corev1.EnvVar{Name: EnvVarCohIdentity, Value: deployment.Name + "@" + deployment.Namespace})
 	}
 

api/v1/constants.go

@@ -39,7 +39,7 @@ const (
 	StatusSelectorTemplate = LabelCoherenceCluster + "=%s," + LabelCoherenceDeployment + "=%s"
 
 	// Feature annotations
-	ANNOTATION_FEATURE_SUSPEND = "com.oracle.coherence.operator/feature.suspend"
+	AnnotationFeatureSuspend = "com.oracle.coherence.operator/feature.suspend"
 
 	// The default k8s service account name.
 	DefaultServiceAccount = "default"

controllers/statefulset/probe.go

@@ -87,9 +87,9 @@ func (in *CoherenceProbe) SuspendServices(deployment *coh.Coherence, sts *appsv1
 	}
 
 	// check whether the Coherence deployment supports service suspension
-	if deployment.Annotations[coh.ANNOTATION_FEATURE_SUSPEND] != "true" {
+	if deployment.Annotations[coh.AnnotationFeatureSuspend] != "true" {
 		log.Info("Skipping suspension of Coherence services in StatefulSet "+sts.Name+
-			coh.ANNOTATION_FEATURE_SUSPEND+" annotation is missing or not set to true",
+			coh.AnnotationFeatureSuspend+" annotation is missing or not set to true",
 			"Namespace", deployment.Namespace, "Name", deployment.Name)
 		return true
 	}