Skip to content

Commit 46c816d

Browse files
authored
COH-27674 - Regenerate gRPC Python stubs using 22.06.4 proto files and use release 22.06.4 (#4)
1 parent 94d40af commit 46c816d

File tree

9 files changed

+17
-316
lines changed

9 files changed

+17
-316
lines changed

Makefile

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,9 +106,12 @@ build-test-images: ## Build the Test images
106106
.PHONY: generate-proto
107107
generate-proto: ## Generate Proto Files
108108
mkdir -p $(PROTO_DIR) || true
109-
curl -o $(PROTO_DIR)/services.proto https://raw.githubusercontent.com/oracle/coherence/v21.12/prj/coherence-grpc/src/main/proto/services.proto
110-
curl -o $(PROTO_DIR)/messages.proto https://raw.githubusercontent.com/oracle/coherence/v21.12/prj/coherence-grpc/src/main/proto/messages.proto
109+
curl -o $(PROTO_DIR)/services.proto https://raw.githubusercontent.com/oracle/coherence/22.06.4/prj/coherence-grpc/src/main/proto/services.proto
110+
curl -o $(PROTO_DIR)/messages.proto https://raw.githubusercontent.com/oracle/coherence/22.06.4/prj/coherence-grpc/src/main/proto/messages.proto
111111
python -m grpc_tools.protoc --proto_path=$(CURRDIR)/etc/proto --python_out=$(CURRDIR)/coherence --grpc_python_out=$(CURRDIR)/coherence $(CURRDIR)/etc/proto/messages.proto $(CURRDIR)/etc/proto/services.proto
112+
sed -e 's/import messages_pb2 as messages__pb2/import coherence.messages_pb2 as messages__pb2/' \
113+
< $(CURRDIR)/coherence/services_pb2_grpc.py > $(CURRDIR)/coherence/services_pb2_grpc.py.out
114+
mv $(CURRDIR)/coherence/services_pb2_grpc.py.out $(CURRDIR)/coherence/services_pb2_grpc.py
112115

113116
# ----------------------------------------------------------------------------------------------------------------------
114117
# Run tests with code coverage

coherence/client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
from .comparator import Comparator
3535
from .event import MapLifecycleEvent, MapListener, SessionLifecycleEvent
3636
from .filter import AlwaysFilter, Filter
37-
from .messages_pb2 import PageRequest
37+
from .messages_pb2 import PageRequest # type: ignore
3838
from .processor import EntryProcessor
3939
from .serialization import Serializer, SerializerRegistry
4040
from .services_pb2_grpc import NamedCacheServiceStub

coherence/event.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
import coherence.client
1818
from coherence.filter import Filter, Filters, MapEventFilter
19-
from coherence.messages_pb2 import MapEventResponse, MapListenerRequest, MapListenerResponse
19+
from coherence.messages_pb2 import MapEventResponse, MapListenerRequest, MapListenerResponse # type: ignore
2020
from coherence.serialization import Serializer
2121
from coherence.services_pb2_grpc import NamedCacheServiceStub
2222
from coherence.util import RequestFactory

coherence/messages_pb2.py

Lines changed: 3 additions & 302 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

coherence/services_pb2.py

Lines changed: 3 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

coherence/util.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
from .aggregator import EntryAggregator
1111
from .comparator import Comparator
1212
from .filter import Filter, Filters, MapEventFilter
13-
from .messages_pb2 import (
13+
from .messages_pb2 import ( # type: ignore
1414
AggregateRequest,
1515
ClearRequest,
1616
ContainsKeyRequest,

tests/java/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
<maven.compiler.target>8</maven.compiler.target>
3535

3636
<coherence.group.id>com.oracle.coherence.ce</coherence.group.id>
37-
<coherence.version>22.06.2</coherence.version>
37+
<coherence.version>22.06.4</coherence.version>
3838

3939
<!-- The version of Coherence to use in the test images -->
4040
<coherence.test.groupId>com.oracle.coherence.ce</coherence.test.groupId>

tests/scripts/run-tests.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ set -e
1414

1515
echo "Coherence CE 22.06.2"
1616
COHERENCE_CLIENT_REQUEST_TIMEOUT=180.0 \
17-
COHERENCE_VERSION=22.06.2 \
17+
COHERENCE_VERSION=22.06.4 \
1818
make clean test-cluster-shutdown remove-app-images build-test-images test-cluster-startup just-wait test
1919

2020
echo "Coherence CE 22.06.2 with SSL"
@@ -23,5 +23,5 @@ RUN_SECURE=true COHERENCE_IGNORE_INVALID_CERTS=true \
2323
COHERENCE_TLS_CLIENT_CERT=$(pwd)/tests/utils/certs/star-lord.crt \
2424
COHERENCE_TLS_CLIENT_KEY=$(pwd)/tests/utils/certs/star-lord.pem \
2525
COHERENCE_CLIENT_REQUEST_TIMEOUT=180.0 \
26-
COHERENCE_VERSION=22.06.2 PROFILES=,secure make clean certs test-cluster-shutdown remove-app-images \
26+
COHERENCE_VERSION=22.06.4 PROFILES=,secure make clean certs test-cluster-shutdown remove-app-images \
2727
build-test-images test-cluster-startup just-wait test

tests/test_client.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -299,7 +299,6 @@ async def test_values_filtered(setup_and_teardown: NamedCache[str, str]) -> None
299299

300300
# noinspection PyShadowingNames
301301
@pytest.mark.asyncio
302-
@pytest.mark.skip
303302
async def test_values_paged(setup_and_teardown: NamedCache[str, str]) -> None:
304303
cache: NamedCache[str, str] = setup_and_teardown
305304

0 commit comments

Comments
 (0)