lint fixes

Author: s1saurabh

OracleDatabase/RAC/OracleRealApplicationClusters/samples/applypatch/buildPatchedContainerImage.sh

@@ -11,7 +11,6 @@ It builds a patched RAC container image
 
 Parameters:
    -v: version to build
-       Choose one of: $(for i in $(ls -d */); do echo -n "${i%%/}  "; done)
    -o: passes on container build option
    -p: patch label to be used for the tag
 
@@ -32,8 +31,11 @@ if [ "$#" -eq 0 ]; then
 fi
 
 # Parameters
+# shellcheck disable=SC2034
 ENTERPRISE=0
+# shellcheck disable=SC2034
 STANDARD=0
+# shellcheck disable=SC2034
 LATEST="latest"
 VERSION='x'
 PATCHLABEL="patch"
@@ -68,26 +70,28 @@ done
 IMAGE_NAME="oracle/database-rac:$VERSION-$PATCHLABEL"
 
 # Go into version folder
+# shellcheck disable=SC2164
 cd latest
 
 # Proxy settings
 PROXY_SETTINGS=""
+# shellcheck disable=SC2154
 if [ "${http_proxy}" != "" ]; then
   PROXY_SETTINGS="$PROXY_SETTINGS --build-arg http_proxy=${http_proxy}"
 fi
-
+# shellcheck disable=SC2154
 if [ "${https_proxy}" != "" ]; then
   PROXY_SETTINGS="$PROXY_SETTINGS --build-arg https_proxy=${https_proxy}"
 fi
-
+# shellcheck disable=SC2154
 if [ "${ftp_proxy}" != "" ]; then
   PROXY_SETTINGS="$PROXY_SETTINGS --build-arg ftp_proxy=${ftp_proxy}"
 fi
-
+# shellcheck disable=SC2154
 if [ "${no_proxy}" != "" ]; then
   PROXY_SETTINGS="$PROXY_SETTINGS --build-arg no_proxy=${no_proxy}"
 fi
-
+# shellcheck disable=SC2154
 if [ "$PROXY_SETTINGS" != "" ]; then
   echo "Proxy settings were found and will be used during the build."
 fi
@@ -100,22 +104,22 @@ echo "Building image '$IMAGE_NAME' ..."
 # BUILD THE IMAGE (replace all environment variables)
 BUILD_START=$(date '+%s')
 docker build --no-cache=true $DOCKEROPS $PROXY_SETTINGS -t env -f ContainerfileEnv .
-
-docker cp $(docker create --name env --rm env):/tmp/.env ./ 
-
+# shellcheck disable=SC2046
+docker cp $(docker create --name env-070125 --rm env):/tmp/.env ./ 
+# shellcheck disable=SC2046
 docker build --no-cache=true $DOCKEROPS \
              --build-arg GRID_HOME=$(grep GRID_HOME .env | cut -d '=' -f2) \
              --build-arg DB_HOME=$(grep DB_HOME .env | cut -d '=' -f2) $PROXY_SETTINGS -t $IMAGE_NAME -f Containerfile . || {
   echo "There was an error building the image."
   exit 1
 }
-docker rmi -f env
+docker rmi -f env-070125
 
 BUILD_END=$(date '+%s')
 BUILD_ELAPSED=`expr $BUILD_END - $BUILD_START`
 
 echo ""
-
+# shellcheck disable=SC2320
 if [ $? -eq 0 ]; then
 cat << EOF
   Oracle Database container image for Real Application Clusters (RAC) version $VERSION is ready to be extended:

OracleDatabase/RAC/OracleRealApplicationClusters/samples/applypatch/latest/Containerfile

@@ -112,6 +112,7 @@ WORKDIR $WORKDIR
 HEALTHCHECK --interval=2m --start-period=30m \
    CMD "$SCRIPT_DIR/scripts/main.py --checkracinst=true" >/dev/null || exit 1
 #Fix SID detection
+# hadolint ignore=SC2086
 RUN $INVENTORY/orainstRoot.sh && \
     $GRID_HOME/root.sh && \
     $DB_HOME/root.sh