Lint errors fix

Author: adhrames

OracleSOASuite/dockerfiles/14.1.2.0/Containerfile

@@ -29,7 +29,7 @@ ENV FMW_JAR1=fmw_14.1.2.0.0_soa.jar \
 #
 # Copy installers and patches for install
 # -------------------------------------------
-ADD  $FMW_JAR1 $FMW_JAR2 $FMW_JAR3 /u01/
+COPY  $FMW_JAR1 $FMW_JAR2 $FMW_JAR3 /u01/
 RUN mkdir /u01/patches  ${OPATCH_PATCH_DIR} && \
     chown oracle:root -R /u01
 COPY patches/* /u01/patches/
@@ -120,7 +120,7 @@ LABEL "provider"="Oracle"
 # -----------------------------
 USER root
 ENV PATH=$PATH:/u01/oracle/container-scripts:/u01/oracle/oracle_common/modules/thirdparty/org.apache.ant/apache-ant/bin
-RUN microdnf install hostname && \
+RUN microdnf install -y hostname && \
     microdnf clean all
 
 COPY --from=builder --chown=oracle:root /u01 /u01

OracleSOASuite/dockerfiles/14.1.2.0/container-scripts/build.xml

@@ -26,12 +26,6 @@ function _term() {
   exit;
 }
 
-#==================================================
-function _kill() {
-  echo "INFO: SIGKILL received, shutting down Admin Server!"
-  /u01/oracle/user_projects/domains/base_domain/bin/stopWebLogic.sh
-  exit;
-}
 
 #==================================================
 function rand_pwd(){
@@ -57,7 +51,7 @@ setupRCU() {
     cp ${scrName} ${scrName}.orig
   fi
 
-  if [ "${dbType}" = "XE" -o "${dbType}" = "xe" ]; then
+  if [ "${dbType}" = "XE" ] || [ "${dbType}" = "xe" ]; then
     echo "INFO: Setting RCU for XE"
     sed -e "s/^@@prepareAuditView.sql/-- @@prepareAuditView.sql/g" ${scrName}.orig > ${scrName}
   else
@@ -70,7 +64,8 @@ setupRCU() {
 updateListenAddress() {
   mkdir -p ${DOMAIN_HOME}/logs
 
-  export thehost=`hostname -I`
+  thehost=`hostname -I`
+  export thehost
   echo "INFO: Updating the listen address - ${thehost}"
   cmd="/u01/oracle/oracle_common/common/bin/wlst.sh -skipWLSModuleScanning /u01/oracle/container-scripts/updListenAddress.py $vol_name ${thehost} AdminServer"
   echo ${cmd}
@@ -82,7 +77,6 @@ updateListenAddress() {
 #==================================================
 trap _int SIGINT
 trap _term SIGTERM
-trap _kill SIGKILL
 
 echo "INFO: CONNECTION_STRING = ${CONNECTION_STRING:?"Please set CONNECTION_STRING"}"
 echo "INFO: RCUPREFIX         = ${RCUPREFIX:?"Please set RCUPREFIX"}"
@@ -109,7 +103,7 @@ then
   # Auto generate Oracle Database Schema password
   temp_pwd=$(rand_pwd)
   #Password should not start with a number for database
-  f_str=`echo $temp_pwd|cut -c1|tr [0-9] [A-Z]`
+  f_str=$(echo "$temp_pwd" | cut -c1 | tr '0-9' 'A-Z')
   s_str=`echo $temp_pwd|cut -c2-`
   DB_SCHEMA_PASSWORD=${f_str}${s_str}
   echo ""

OracleSOASuite/dockerfiles/14.1.2.0/container-scripts/createDomainAndStart.sh

@@ -62,7 +62,8 @@ LOGDIR=${DOMAIN_HOME}/logs/${MANAGED_SERVER}
 LOGFILE=${LOGDIR}/ms.log
 mkdir -p ${LOGDIR}
 
-export thehost=`hostname -I`
+thehost=`hostname -I`
+export thehost
 echo "INFO: Updating the listen address - ${thehost}"
 /u01/oracle/oracle_common/common/bin/wlst.sh -skipWLSModuleScanning /u01/oracle/container-scripts/updListenAddress.py $vol_name $thehost ${MANAGED_SERVER} > ${LOGDIR}/mslisten.log 2>&1
 

OracleSOASuite/dockerfiles/14.1.2.0/container-scripts/get_healthcheck_url.sh

@@ -127,7 +127,7 @@ fi
 
 
 # Go into version folder
-cd ${THEDIR}
+cd "${THEDIR}" || exit 1
 
 checkFilePackages
 checksumPackages