Skip to content

Commit 029e2a7

Browse files
committed
[GR-65750] Remove unnecessary dependency on sulong-managed
1 parent 76f0980 commit 029e2a7

File tree

4 files changed

+5
-13
lines changed

4 files changed

+5
-13
lines changed

espresso/mx.espresso/jvm-ee-llvm

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
# /vm-enterprise,/substratevm-enterprise,/truffle-enterprise,/sulong-managed,/tools-enterprise,/regex with EE components, with libgraal, doesn't build native standalone
2-
DYNAMIC_IMPORTS=/vm-enterprise,/substratevm-enterprise,/truffle-enterprise,/sulong-managed,/tools-enterprise,/regex
1+
# /vm-enterprise,/substratevm-enterprise,/truffle-enterprise,/sulong,/tools-enterprise,/regex with EE components, with libgraal, doesn't build native standalone
2+
DYNAMIC_IMPORTS=/vm-enterprise,/substratevm-enterprise,/truffle-enterprise,/sulong,/tools-enterprise,/regex
33
COMPONENTS=cmp,cmpee,gvm,jipher,lg,ni,nic,niee,nil,sdkni,svm,svmjdwp,svmt,svmee,svmte,svmsl,tflc,tflsm
44
NATIVE_IMAGES=lib:jvmcicompiler
55
NON_REBUILDABLE_IMAGES=lib:jvmcicompiler

espresso/mx.espresso/mx_espresso.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -140,11 +140,6 @@ def jvm_standalone_deps():
140140
"sulong:SULONG_NATIVE",
141141
"sulong:SULONG_NFI",
142142
]
143-
if mx.suite('sulong-managed', fatalIfMissing=False):
144-
result += [
145-
'sulong-managed:SULONG_ENTERPRISE',
146-
'sulong-managed:SULONG_ENTERPRISE_NATIVE',
147-
]
148143
if mx.suite('truffle-enterprise', fatalIfMissing=False):
149144
result.append('truffle-enterprise:TRUFFLE_ENTERPRISE')
150145
return result

espresso/mx.espresso/suite.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -915,8 +915,6 @@
915915
# - sulong:SULONG_CORE
916916
# - sulong:SULONG_NATIVE
917917
# - sulong:SULONG_NFI
918-
# - sulong-managed:SULONG_ENTERPRISE
919-
# - sulong-managed:SULONG_ENTERPRISE_NATIVE
920918
# - truffle-enterprise:TRUFFLE_ENTERPRISE
921919
"dynamicDistDependencies": "jvm_standalone_deps",
922920
"maven": False,

sulong/mx.sulong/mx_sulong.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -114,13 +114,12 @@ def sulong_standalone_deps():
114114
include_truffle_runtime = not mx.env_var_to_bool("EXCLUDE_TRUFFLE_RUNTIME")
115115
deps = mx_truffle.resolve_truffle_dist_names(use_optimized_runtime=include_truffle_runtime)
116116
if has_suite('sulong-managed'):
117-
# SULONG_ENTERPRISE and SULONG_MANAGED do not belong in the EE standalone of SULONG_NATIVE, but we want a single definition of libllvmvm.
118-
# So we compromise here by including them. We do not use or distribute the EE standalone of SULONG_NATIVE so it does not matter.
117+
# SULONG_MANAGED does not belong in the EE standalone of SULONG_NATIVE, but we want a single definition of libllvmvm.
118+
# So we compromise here by including SULONG_MANAGED if sulong-managed is imported.
119+
# We do not use or distribute the EE standalone of SULONG_NATIVE so it does not matter.
119120
# See also the comments in suite.py, in SULONG_*_STANDALONE_RELEASE_ARCHIVE.
120121
deps += [
121-
'sulong-managed:SULONG_ENTERPRISE',
122122
'sulong-managed:SULONG_MANAGED',
123-
'sulong-managed:SULONG_ENTERPRISE_NATIVE',
124123
]
125124
return deps
126125

0 commit comments

Comments
 (0)