Minor warning cleanups

gilles-duboscq · gilles-duboscq · commit 0bb6ddc9d43a · 2025-11-19T20:19:16.000+01:00
diff --git a/espresso/src/com.oracle.truffle.espresso/src/com/oracle/truffle/espresso/ffi/Callback.java b/espresso/src/com.oracle.truffle.espresso/src/com/oracle/truffle/espresso/ffi/Callback.java
@@ -40,8 +40,8 @@ public Callback(int arity, Function function) {
         this.function = function;
     }
 
-    @SuppressWarnings("static-method")
     @ExportMessage
+    @SuppressWarnings("static-method")
     boolean isExecutable() {
         return true;
     }
diff --git a/espresso/src/com.oracle.truffle.espresso/src/com/oracle/truffle/espresso/nodes/IntrinsicSubstitutorNode.java b/espresso/src/com.oracle.truffle.espresso/src/com/oracle/truffle/espresso/nodes/IntrinsicSubstitutorNode.java
@@ -116,7 +116,6 @@ public boolean hasScope(@SuppressWarnings("unused") Frame frame) {
     }
 
     @ExportMessage
-    @SuppressWarnings("static-method")
     public Object getScope(Frame frame, @SuppressWarnings("unused") boolean nodeEnter) {
         return new SubstitutionScope(frame.getArguments(), getMethodVersion());
     }
diff --git a/espresso/src/com.oracle.truffle.espresso/src/com/oracle/truffle/espresso/nodes/IntrinsifiedNativeMethodNode.java b/espresso/src/com.oracle.truffle.espresso/src/com/oracle/truffle/espresso/nodes/IntrinsifiedNativeMethodNode.java
@@ -69,7 +69,6 @@ public boolean hasScope(@SuppressWarnings("unused") Frame frame) {
     }
 
     @ExportMessage
-    @SuppressWarnings("static-method")
     public Object getScope(Frame frame, @SuppressWarnings("unused") boolean nodeEnter) {
         return new SubstitutionScope(frame.getArguments(), getMethodVersion());
     }
diff --git a/espresso/src/com.oracle.truffle.espresso/src/com/oracle/truffle/espresso/nodes/commands/AddPathToBindingsNode.java b/espresso/src/com.oracle.truffle.espresso/src/com/oracle/truffle/espresso/nodes/commands/AddPathToBindingsNode.java
@@ -62,6 +62,7 @@ public boolean isExecutable() {
         }
 
         @ExportMessage
+        @SuppressWarnings("static-method")
         public Object execute(Object[] args,
                         @Cached AddPathToBindingsNode addPath) throws ArityException, UnsupportedTypeException {
             // Args are checked in addPathToBindingsNode.
diff --git a/espresso/src/com.oracle.truffle.espresso/src/com/oracle/truffle/espresso/nodes/quick/BaseQuickNode.java b/espresso/src/com.oracle.truffle.espresso/src/com/oracle/truffle/espresso/nodes/quick/BaseQuickNode.java
@@ -48,6 +48,7 @@ public abstract class BaseQuickNode extends EspressoNode implements BciProvider,
 
     public abstract int execute(VirtualFrame frame, boolean isContinuationResume);
 
+    @Override
     public boolean isInstrumentable() {
         return true;
     }
diff --git a/espresso/src/com.oracle.truffle.espresso/src/com/oracle/truffle/espresso/runtime/dispatch/staticobject/MapInterop.java b/espresso/src/com.oracle.truffle.espresso/src/com/oracle/truffle/espresso/runtime/dispatch/staticobject/MapInterop.java
@@ -177,7 +177,6 @@ public static void removeHashEntry(StaticObject receiver, Object key,
         }
     }
 
-    @SuppressWarnings("static-method")
     @ExportMessage
     public static Object getHashEntriesIterator(StaticObject receiver,
                     @CachedLibrary(limit = "1") InteropLibrary setLibrary,

Original file line number	Diff line number	Diff line change
`@@ -40,8 +40,8 @@ public Callback(int arity, Function function) {`
`40`	`40`	`this.function = function;`
`41`	`41`	`}`
`42`	`42`
`43`		`- @SuppressWarnings("static-method")`
`44`	`43`	`@ExportMessage`
	`44`	`+ @SuppressWarnings("static-method")`
`45`	`45`	`boolean isExecutable() {`
`46`	`46`	`return true;`
`47`	`47`	`}`
Original file line number	Diff line number	Diff line change
`@@ -116,7 +116,6 @@ public boolean hasScope(@SuppressWarnings("unused") Frame frame) {`
`116`	`116`	`}`
`117`	`117`
`118`	`118`	`@ExportMessage`
`119`		`- @SuppressWarnings("static-method")`
`120`	`119`	`public Object getScope(Frame frame, @SuppressWarnings("unused") boolean nodeEnter) {`
`121`	`120`	`return new SubstitutionScope(frame.getArguments(), getMethodVersion());`
`122`	`121`	`}`
Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,6 @@ public boolean hasScope(@SuppressWarnings("unused") Frame frame) {`
`69`	`69`	`}`
`70`	`70`
`71`	`71`	`@ExportMessage`
`72`		`- @SuppressWarnings("static-method")`
`73`	`72`	`public Object getScope(Frame frame, @SuppressWarnings("unused") boolean nodeEnter) {`
`74`	`73`	`return new SubstitutionScope(frame.getArguments(), getMethodVersion());`
`75`	`74`	`}`
Original file line number	Diff line number	Diff line change
`@@ -62,6 +62,7 @@ public boolean isExecutable() {`
`62`	`62`	`}`
`63`	`63`
`64`	`64`	`@ExportMessage`
	`65`	`+ @SuppressWarnings("static-method")`
`65`	`66`	`public Object execute(Object[] args,`
`66`	`67`	`@Cached AddPathToBindingsNode addPath) throws ArityException, UnsupportedTypeException {`
`67`	`68`	`// Args are checked in addPathToBindingsNode.`
Original file line number	Diff line number	Diff line change
`@@ -48,6 +48,7 @@ public abstract class BaseQuickNode extends EspressoNode implements BciProvider,`
`48`	`48`
`49`	`49`	`public abstract int execute(VirtualFrame frame, boolean isContinuationResume);`
`50`	`50`
	`51`	`+ @Override`
`51`	`52`	`public boolean isInstrumentable() {`
`52`	`53`	`return true;`
`53`	`54`	`}`
Original file line number	Diff line number	Diff line change
`@@ -177,7 +177,6 @@ public static void removeHashEntry(StaticObject receiver, Object key,`
`177`	`177`	`}`
`178`	`178`	`}`
`179`	`179`
`180`		`- @SuppressWarnings("static-method")`
`181`	`180`	`@ExportMessage`
`182`	`181`	`public static Object getHashEntriesIterator(StaticObject receiver,`
`183`	`182`	`@CachedLibrary(limit = "1") InteropLibrary setLibrary,`