Skip to content

Commit 0e9791b

Browse files
committed
Add missing module property in BundleConfiguration and JSON printing
1 parent f93ebe6 commit 0e9791b

File tree

2 files changed

+13
-4
lines changed

2 files changed

+13
-4
lines changed

substratevm/src/com.oracle.svm.configure/src/com/oracle/svm/configure/config/ResourceConfiguration.java

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,17 +116,23 @@ public void addClassBasedResourceBundle(UnresolvedConfigurationCondition conditi
116116

117117
public static final class BundleConfiguration {
118118
public final UnresolvedConfigurationCondition condition;
119+
public final String module;
119120
public final String baseName;
120121
public final Set<String> locales = ConcurrentHashMap.newKeySet();
121122
public final Set<String> classNames = ConcurrentHashMap.newKeySet();
122123

123-
public BundleConfiguration(UnresolvedConfigurationCondition condition, String baseName) {
124+
public BundleConfiguration(UnresolvedConfigurationCondition condition, String module, String baseName) {
124125
this.condition = condition;
126+
this.module = module;
125127
this.baseName = baseName;
126128
}
127129

130+
public BundleConfiguration(UnresolvedConfigurationCondition condition, String baseName) {
131+
this(condition, null, baseName);
132+
}
133+
128134
private BundleConfiguration(BundleConfiguration other) {
129-
this(other.condition, other.baseName);
135+
this(other.condition, other.module, other.baseName);
130136
locales.addAll(other.locales);
131137
classNames.addAll(other.classNames);
132138
}
@@ -389,6 +395,9 @@ public ConfigurationParser createParser(boolean combinedFileSchema, EnumSet<Conf
389395
public static void printResourceBundle(BundleConfiguration config, JsonWriter writer, boolean combinedFile) throws IOException {
390396
writer.appendObjectStart();
391397
ConfigurationConditionPrintable.printConditionAttribute(config.condition, writer, combinedFile);
398+
if (config.module != null) {
399+
writer.quote("module").appendFieldSeparator().quote(config.module).appendSeparator();
400+
}
392401
writer.quote(combinedFile ? BUNDLE_KEY : NAME_KEY).appendFieldSeparator().quote(config.baseName);
393402
if (!combinedFile && !config.locales.isEmpty()) {
394403
writer.appendSeparator().quote("locales").appendFieldSeparator();

substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/jdk/resources/MissingResourceRegistrationUtils.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,14 +63,14 @@ public static void reportResourceAccess(Module module, String resourcePath) {
6363
}
6464

6565
public static void reportResourceBundleAccess(Module module, String baseName) {
66-
var bundleConfig = new ResourceConfiguration.BundleConfiguration(UnresolvedConfigurationCondition.alwaysTrue(), baseName);
66+
Objects.requireNonNull(module);
67+
var bundleConfig = new ResourceConfiguration.BundleConfiguration(UnresolvedConfigurationCondition.alwaysTrue(), module.getName(), baseName);
6768
StringWriter json = new StringWriter();
6869
try {
6970
ResourceConfiguration.printResourceBundle(bundleConfig, getJSONWriter(json), true);
7071
} catch (IOException e) {
7172
throw VMError.shouldNotReachHere("In memory JSON printing should not fail");
7273
}
73-
Objects.requireNonNull(module);
7474
String moduleMessage = module.isNamed() ? " from module " + quote(module.getName()) : "";
7575
MissingResourceRegistrationError exception = new MissingResourceRegistrationError(
7676
resourceError("resource bundle" + moduleMessage + " with name " + quote(baseName), json.toString(), "resource-bundles"),

0 commit comments

Comments
 (0)