[GR-67702] No warning at usages of nodes annotated with @GenerateInline(false)

* That annotation means the intention is for that node to not be inlineable.

Author: eregon

truffle/CHANGELOG.md

@@ -5,6 +5,7 @@ This changelog summarizes major changes between Truffle versions relevant to lan
 ## Version 26.0
 * GR-65048: Introduced `InternalResource.OS.UNSUPPORTED` and `InternalResource.CPUArchitecture.UNSUPPORTED` to represent unsupported platforms. Execution on unsupported platforms must be explicitly enabled using the system property `-Dpolyglot.engine.allowUnsupportedPlatform=true`. If this property is not set, calls to `OS.getCurrent()` or `CPUArchitecture.getCurrent()` will throw an `IllegalStateException` when running on an unsupported platform. `InternalResource` implementations should handle the unsupported platform and describe possible steps in the error message on how to proceed.
 * GR-66839: Deprecate `Location#isFinal()` as it always returns false.
+* GR-67702: If a node is annotated with `@GenerateInline(false)` it is no longer warned at usages inside an inlined node, that is `@GenerateInline(false)` is considered a conscious decision to make that node not inlined.
 
 ## Version 25.0
 * GR-31495 Added ability to specify language and instrument specific options using `Source.Builder.option(String, String)`. Languages may describe available source options by implementing `TruffleLanguage.getSourceOptionDescriptors()` and `TruffleInstrument.getSourceOptionDescriptors()` respectively.

truffle/src/com.oracle.truffle.api.dsl.test/src/com/oracle/truffle/api/dsl/test/GenerateInlineTest.java

@@ -1796,7 +1796,8 @@ public abstract static class ErrorNotInlinableNode extends Node {
 
         @Specialization()
         Object doInt(int arg,
-                        @ExpectError("The cached node type does not support object inlining. Add @GenerateInline on the node type or disable inline using @Cached(inline=false) to resolve this.") @Cached(inline = true) NoInliningNode simpleNode) {
+                        @ExpectError("The cached node type does not support object inlining. " +
+                                        "Add @GenerateInline or @GenerateInline(false) on the node type or disable inlining using @Cached(inline=false) to resolve this.") @Cached(inline = true) NoInliningNode simpleNode) {
             return "";
         }
 

truffle/src/com.oracle.truffle.dsl.processor/src/com/oracle/truffle/dsl/processor/parser/NodeParser.java

@@ -3761,13 +3761,15 @@ private void parseCached(CacheExpression cache, SpecializationData specializatio
             if (declaresInline) {
                 cache.addError(cachedAnnotation, getAnnotationValue(cachedAnnotation, "inline"),
                                 "The cached node type does not support object inlining." + //
-                                                " Add @%s on the node type or disable inline using @%s(inline=false) to resolve this.",
+                                                " Add @%s or @%s(false) on the node type or disable inlining using @%s(inline=false) to resolve this.",
+                                getSimpleName(types.GenerateInline),
                                 getSimpleName(types.GenerateInline),
                                 getSimpleName(types.Cached));
-            } else if (node.isGenerateInline()) {
+            } else if (node.isGenerateInline() && !isGenerateInlineFalse(cache)) {
                 cache.addSuppressableWarning(TruffleSuppressedWarnings.INLINING_RECOMMENDATION,
                                 "The cached node type does not support object inlining." + //
-                                                " Add @%s on the node type or disable inline using @%s(inline=false) to resolve this.",
+                                                " Add @%s or @%s(false) on the node type or disable inlining using @%s(inline=false) to resolve this.",
+                                getSimpleName(types.GenerateInline),
                                 getSimpleName(types.GenerateInline),
                                 getSimpleName(types.Cached));
                 inline = false;
@@ -4162,6 +4164,20 @@ private boolean forceInlineByDefault(CacheExpression cache) {
         return false;
     }
 
+    private boolean isGenerateInlineFalse(CacheExpression cache) {
+        TypeElement parameterType = ElementUtils.castTypeElement(cache.getParameter().getType());
+        if (parameterType == null) {
+            return false;
+        }
+        if (ElementUtils.isAssignable(parameterType.asType(), types.Node)) {
+            AnnotationMirror inlineAnnotation = getGenerateInlineAnnotation(parameterType);
+            if (inlineAnnotation != null && getAnnotationValue(Boolean.class, inlineAnnotation, "value") == false) {
+                return true;
+            }
+        }
+        return false;
+    }
+
     private static boolean hasInlineMethod(CacheExpression cache) {
         TypeMirror type = cache.getParameter().getType();
         TypeElement parameterType = ElementUtils.castTypeElement(type);