Resolved review comments.

Author: tzezula

substratevm/src/com.oracle.svm.truffle.tck/src/com/oracle/svm/truffle/tck/PermissionsFeature.java

@@ -129,9 +129,22 @@ public enum ActionKind {
         Throw
     }
 
+    /**
+     * Specifies how privileged method violations are reported. See
+     * {@link Options#TruffleTCKCollectMode}.
+     */
     public enum CollectMode {
+        /**
+         * Reports only one violation in total.
+         */
         Single,
+        /**
+         * Reports one call path per privileged method used.
+         */
         SinglePrivilegedMethodUsage,
+        /**
+         * Reports all call paths for all violations.
+         */
         All
     }
 
@@ -386,7 +399,14 @@ public void afterAnalysis(AfterAnalysisAccess access) {
                                 (pw) -> {
                                     StringBuilder builder = new StringBuilder();
                                     for (List<BaseMethodNode> callPath : report) {
+                                        boolean privilegedMethod = true;
                                         for (BaseMethodNode call : callPath) {
+                                            if (privilegedMethod) {
+                                                builder.append("Illegal call to privileged method ");
+                                                privilegedMethod = false;
+                                            } else {
+                                                builder.append("    at ");
+                                            }
                                             builder.append(call.asStackTraceElement()).append(System.lineSeparator());
                                         }
                                         builder.append(System.lineSeparator());

vm/mx.vm/mx_vm_gate.py

@@ -645,6 +645,9 @@ def _collect_excludes(suite, suite_import, excludes):
             with open(report_file, "r") as f:
                 for line in f.readlines():
                     message = message + line
+            message = message + ("\nNote: If the method is not used directly by the language, but is part of the call path "
+                                 "because it is used internally by the JDK and introduced by a polymorphic call, consider "
+                                 "adding it to `jdk_allowed_methods.json`.")
             if fail_on_error:
                 mx.abort(message)
             else: