Skip to content

Commit 4325c69

Browse files
committed
Fix test assumptions.
1 parent ed5aa9a commit 4325c69

File tree

5 files changed

+21
-9
lines changed

5 files changed

+21
-9
lines changed

truffle/src/com.oracle.truffle.api.object.test/src/com/oracle/truffle/object/basic/test/DOTestAsserts.java

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,9 @@
4040
*/
4141
package com.oracle.truffle.object.basic.test;
4242

43+
import static org.hamcrest.CoreMatchers.either;
44+
import static org.hamcrest.CoreMatchers.endsWith;
45+
import static org.hamcrest.MatcherAssert.assertThat;
4346
import static org.junit.Assert.assertEquals;
4447
import static org.junit.Assert.assertTrue;
4548

@@ -141,6 +144,14 @@ public static Class<?> getLocationType(Location location) {
141144
}
142145
}
143146

147+
public static void assumeExtLayout() {
148+
Shape shape = Shape.newBuilder().build();
149+
assertThat("Unexpected Shape class name (the assertion may need to be updated if the code is refactored)",
150+
shape.getClass().getName(), either(endsWith("ShapeExt")).or(endsWith("ShapeBasic")));
151+
Assume.assumeTrue("Test is specific to the Extended Dynamic Object Layout",
152+
shape.getClass().getName().endsWith("ShapeExt"));
153+
}
154+
144155
public static Location assumeCoreLocation(Location location) {
145156
Assume.assumeTrue(isCoreLocation(location));
146157
return location;

truffle/src/com.oracle.truffle.api.object.test/src/com/oracle/truffle/object/ext/test/GR42603.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,8 @@
4040
*/
4141
package com.oracle.truffle.object.ext.test;
4242

43+
import static com.oracle.truffle.object.basic.test.DOTestAsserts.assumeExtLayout;
44+
4345
import java.util.ArrayList;
4446
import java.util.List;
4547
import java.util.concurrent.ExecutionException;
@@ -54,7 +56,6 @@
5456
import com.oracle.truffle.api.object.DynamicObjectLibrary;
5557
import com.oracle.truffle.api.object.Shape;
5658
import com.oracle.truffle.object.ext.test.ObjectModelRegressionTest.TestDynamicObject;
57-
import com.oracle.truffle.tck.tests.TruffleTestAssumptions;
5859

5960
public class GR42603 {
6061

@@ -63,7 +64,7 @@ public class GR42603 {
6364

6465
@Test
6566
public void testReplacePropertyRace() throws Throwable {
66-
TruffleTestAssumptions.assumeEnterpriseRuntime();
67+
assumeExtLayout();
6768
for (int i = 0; i < 100; i++) {
6869
testConcurrentReplaceProperty();
6970
}

truffle/src/com.oracle.truffle.api.object.test/src/com/oracle/truffle/object/ext/test/GR52036.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@
4040
*/
4141
package com.oracle.truffle.object.ext.test;
4242

43+
import static com.oracle.truffle.object.basic.test.DOTestAsserts.assumeExtLayout;
4344
import static com.oracle.truffle.object.basic.test.DOTestAsserts.getTypeAssumption;
4445
import static com.oracle.truffle.object.basic.test.DOTestAsserts.getTypeAssumptionRecord;
4546
import static org.junit.Assert.assertFalse;
@@ -55,7 +56,6 @@
5556
import com.oracle.truffle.api.object.DynamicObject;
5657
import com.oracle.truffle.api.object.DynamicObjectLibrary;
5758
import com.oracle.truffle.api.object.Shape;
58-
import com.oracle.truffle.tck.tests.TruffleTestAssumptions;
5959

6060
public class GR52036 {
6161

@@ -70,7 +70,7 @@ public class GR52036 {
7070
@SuppressWarnings("try")
7171
@Test
7272
public void testGR52036Reproducer() throws Throwable {
73-
TruffleTestAssumptions.assumeEnterpriseRuntime();
73+
assumeExtLayout();
7474

7575
class ObjType1 extends DynamicObject {
7676
protected ObjType1(Shape shape) {

truffle/src/com.oracle.truffle.api.object.test/src/com/oracle/truffle/object/ext/test/ObjectModelRegressionTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@
4242

4343
import static com.oracle.truffle.object.basic.test.DOTestAsserts.assertObjectLocation;
4444
import static com.oracle.truffle.object.basic.test.DOTestAsserts.assertPrimitiveLocation;
45+
import static com.oracle.truffle.object.basic.test.DOTestAsserts.assumeExtLayout;
4546
import static com.oracle.truffle.object.basic.test.DOTestAsserts.invokeGetter;
4647
import static org.junit.Assert.assertEquals;
4748
import static org.junit.Assert.assertFalse;
@@ -67,7 +68,6 @@
6768
import com.oracle.truffle.api.object.DynamicObjectLibrary;
6869
import com.oracle.truffle.api.object.Shape;
6970
import com.oracle.truffle.api.test.AbstractParametrizedLibraryTest;
70-
import com.oracle.truffle.tck.tests.TruffleTestAssumptions;
7171

7272
@SuppressWarnings("deprecation")
7373
@RunWith(Parameterized.class)
@@ -386,7 +386,7 @@ public void testChangeFlagsConstantToNonConstant() {
386386

387387
@Test
388388
public void testTryMergeShapes() {
389-
TruffleTestAssumptions.assumeEnterpriseRuntime();
389+
assumeExtLayout();
390390

391391
// Assume (MaxMergeDepth >= 5)
392392
Shape emptyShape = Shape.newBuilder().allowImplicitCastIntToDouble(true).build();
@@ -437,7 +437,7 @@ public void testTryMergeShapes() {
437437

438438
@Test
439439
public void testTryMergeShapes2() {
440-
TruffleTestAssumptions.assumeEnterpriseRuntime();
440+
assumeExtLayout();
441441

442442
// Assume (MaxMergeDepth >= 5 && MaxMergeDiff >= 2)
443443

truffle/src/com.oracle.truffle.api.object.test/src/com/oracle/truffle/object/ext/test/PolymorphicPrimitivesTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@
4242

4343
import static com.oracle.truffle.object.basic.test.DOTestAsserts.assertObjectLocation;
4444
import static com.oracle.truffle.object.basic.test.DOTestAsserts.assertPrimitiveLocation;
45+
import static com.oracle.truffle.object.basic.test.DOTestAsserts.assumeExtLayout;
4546
import static org.junit.Assert.assertEquals;
4647
import static org.junit.Assert.assertSame;
4748
import static org.junit.Assert.assertTrue;
@@ -61,7 +62,6 @@
6162
import com.oracle.truffle.api.object.Shape;
6263
import com.oracle.truffle.api.test.AbstractParametrizedLibraryTest;
6364
import com.oracle.truffle.object.ext.test.ObjectModelRegressionTest.TestDynamicObject;
64-
import com.oracle.truffle.tck.tests.TruffleTestAssumptions;
6565

6666
@SuppressWarnings("deprecation")
6767
@RunWith(Parameterized.class)
@@ -86,7 +86,7 @@ private static DynamicObject newInstance(Shape emptyShape) {
8686

8787
@Before
8888
public void before() {
89-
TruffleTestAssumptions.assumeEnterpriseRuntime();
89+
assumeExtLayout();
9090
}
9191

9292
@Test

0 commit comments

Comments
 (0)