Skip to content

Commit 49a1362

Browse files
committed
Fix mx jvmci-version-check --as-tag for LTS versions.
1 parent 1a5e49e commit 49a1362

File tree

2 files changed

+12
-3
lines changed

2 files changed

+12
-3
lines changed

compiler/mx.compiler/mx_compiler.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -182,8 +182,6 @@ def _capture_jvmci_version(args=None):
182182
if out.data:
183183
try:
184184
(jdk_version, jvmci_major, jvmci_minor, jvmci_build) = out.data.split(',')
185-
if jdk_version.endswith('-LTS'):
186-
jdk_version = jdk_version[:-len('-LTS')]
187185
return JVMCIVersionCheckVersion(JavaLangRuntimeVersion(jdk_version), int(jvmci_major), int(jvmci_minor), int(jvmci_build))
188186
except ValueError:
189187
mx.warn(f'Could not parse jvmci version from JVMCIVersionCheck output:\n{out.data}')

compiler/src/jdk.graal.compiler/src/jdk/graal/compiler/hotspot/JVMCIVersionCheck.java

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,6 +225,17 @@ public String printFormat(PrintFormat format) {
225225
case AS_TAG -> toString();
226226
};
227227
}
228+
229+
public Version stripLTS() {
230+
if ("LTS".equals(jdkVersion.optional().orElse(null))) {
231+
String version = jdkVersion.toString();
232+
assert version.endsWith("-LTS");
233+
String stripped = version.substring(0, version.length() - 4);
234+
return new Version(stripped, jvmciMajor, jvmciMinor, jvmciBuild, legacy, isOpenJDK);
235+
} else {
236+
return this;
237+
}
238+
}
228239
}
229240

230241
public static final String OPEN_LABSJDK_RELEASE_URL_PATTERN = "https://github.com/graalvm/labs-openjdk-*/releases";
@@ -369,7 +380,7 @@ private String run(Version minVersion, PrintFormat format) {
369380
Version v = Version.parse(vmVersion);
370381
if (v != null) {
371382
if (format != null) {
372-
System.out.println(v.printFormat(format));
383+
System.out.println(v.stripLTS().printFormat(format));
373384
}
374385
if (v.isLessThan(minVersion)) {
375386
return String.format("The VM does not support the minimum JVMCI API version required by Graal: %s < %s.", v, minVersion);

0 commit comments

Comments
 (0)