Skip to content

Commit 4b52ca4

Browse files
committed
Stop using final fields in JSObject
It is not allowed by the API docs and now also forbidden in practice
1 parent 4c4677e commit 4b52ca4

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

web-image/src/com.oracle.svm.webimage.jtt/src/com/oracle/svm/webimage/jtt/api/JSObjectSubclassTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,6 +162,7 @@ private static void heapGeneratedObjects() {
162162
inspectHeapOnlyPoint("dummy");
163163
}
164164

165+
// TODO GR-65036 This will have to be updated since the x and y values will be JS primitives
165166
@JS("const { x, y } = dummy.$vm.exports.com.oracle.svm.webimage.jtt.api.HeapOnlyPointStatics.getPoint(); console.log(x.$as('number')); console.log(y.$as('number'));")
166167
private static native void inspectHeapOnlyPoint(String dummy);
167168
}
@@ -212,7 +213,7 @@ public String toString() {
212213

213214
@JS.Export
214215
class SubclassOfImportedJSObject extends ImportedJSObject {
215-
protected final int index;
216+
protected int index;
216217

217218
SubclassOfImportedJSObject(String importDeclaration, int index) {
218219
super(importDeclaration);

0 commit comments

Comments
 (0)