Skip to content

Commit 5a5abc7

Browse files
Fix JFR-related UnsatisfiedLinkErrors.
1 parent ae016b5 commit 5a5abc7

File tree

7 files changed

+211
-70
lines changed

7 files changed

+211
-70
lines changed

substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/VMInspectionOptions.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,12 @@ public static String getHeapDumpNotSupportedMessage() {
141141
SubstrateOptionsParser.commandArgument(EnableMonitoringFeatures, MONITORING_HEAPDUMP_NAME) + "'.";
142142
}
143143

144+
@Fold
145+
public static String getJfrNotSupportedMessage() {
146+
return "JFR is only supported on Linux and MacOS for native binaries built with '" +
147+
SubstrateOptionsParser.commandArgument(EnableMonitoringFeatures, MONITORING_JFR_NAME) + "'.";
148+
}
149+
144150
private static Set<String> getEnabledMonitoringFeatures() {
145151
return new HashSet<>(EnableMonitoringFeatures.getValue().values());
146152
}

substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/jfr/JfrJavaEvents.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -35,22 +35,13 @@
3535
*/
3636
public class JfrJavaEvents {
3737
private static final List<Class<? extends jdk.internal.event.Event>> EVENT_CLASSES = new ArrayList<>();
38-
private static final List<Class<? extends jdk.jfr.Event>> JFR_EVENT_CLASSES = new ArrayList<>();
3938

4039
@Platforms(Platform.HOSTED_ONLY.class)
41-
@SuppressWarnings("unchecked")
4240
public static synchronized void registerEventClass(Class<? extends jdk.internal.event.Event> eventClass) {
4341
EVENT_CLASSES.add(eventClass);
44-
if (jdk.jfr.Event.class.isAssignableFrom(eventClass)) {
45-
JFR_EVENT_CLASSES.add((Class<? extends jdk.jfr.Event>) eventClass);
46-
}
4742
}
4843

4944
public static List<Class<? extends jdk.internal.event.Event>> getAllEventClasses() {
5045
return EVENT_CLASSES;
5146
}
52-
53-
public static List<Class<? extends jdk.jfr.Event>> getJfrEventClasses() {
54-
return JFR_EVENT_CLASSES;
55-
}
5647
}

substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/jfr/JfrJdkCompatibility.java

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,12 @@
3131
import org.graalvm.nativeimage.Platform;
3232
import org.graalvm.nativeimage.Platforms;
3333
import org.graalvm.nativeimage.ProcessProperties;
34+
import org.graalvm.nativeimage.hosted.FieldValueTransformer;
3435

3536
import com.oracle.svm.core.SubstrateOptions;
3637
import com.oracle.svm.core.annotate.Alias;
38+
import com.oracle.svm.core.annotate.RecomputeFieldValue;
39+
import com.oracle.svm.core.annotate.RecomputeFieldValue.Kind;
3740
import com.oracle.svm.core.annotate.Substitute;
3841
import com.oracle.svm.core.annotate.TargetClass;
3942
import com.oracle.svm.core.util.VMError;
@@ -71,14 +74,25 @@ public static void createNativeJFR() {
7174
}
7275
}
7376

74-
@TargetClass(className = "jdk.jfr.internal.JVMSupport", onlyWith = HasJfrSupport.class)
77+
@TargetClass(className = "jdk.jfr.internal.JVMSupport")
7578
final class Target_jdk_jfr_internal_JVMSupport {
79+
@Alias //
80+
@RecomputeFieldValue(kind = Kind.Custom, declClass = JfrNotAvailableTransformer.class, isFinal = true) //
81+
private static boolean notAvailable;
82+
7683
@Substitute
7784
public static String makeFilename(Recording recording) {
7885
return JfrFilenameUtil.makeFilename(recording);
7986
}
8087
}
8188

89+
final class JfrNotAvailableTransformer implements FieldValueTransformer {
90+
@Override
91+
public Object transform(Object receiver, Object originalValue) {
92+
return !HasJfrSupport.get();
93+
}
94+
}
95+
8296
@TargetClass(className = "jdk.jfr.internal.util.ValueFormatter", onlyWith = HasJfrSupport.class)
8397
final class Target_jdk_jfr_internal_util_ValueFormatter {
8498
@Alias

substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/jfr/JfrRecorderThread.java

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -130,21 +130,13 @@ private void persistBuffers(JfrChunkWriter chunkWriter) {
130130
}
131131

132132
if (chunkWriter.shouldRotateDisk()) {
133-
Object chunkRotationMonitor = getChunkRotationMonitor();
133+
Object chunkRotationMonitor = Target_jdk_jfr_internal_JVM.CHUNK_ROTATION_MONITOR;
134134
synchronized (chunkRotationMonitor) {
135135
chunkRotationMonitor.notifyAll();
136136
}
137137
}
138138
}
139139

140-
private static Object getChunkRotationMonitor() {
141-
if (HasChunkRotationMonitorField.get()) {
142-
return Target_jdk_jfr_internal_JVM.CHUNK_ROTATION_MONITOR;
143-
} else {
144-
return Target_jdk_jfr_internal_JVM.FILE_DELTA_CHANGE;
145-
}
146-
}
147-
148140
@Uninterruptible(reason = "Locking without transition requires that the whole critical section is uninterruptible.")
149141
private static void tryPersistBuffer(JfrChunkWriter chunkWriter, JfrBufferNode node) {
150142
if (JfrBufferNodeAccess.tryLock(node)) {

0 commit comments

Comments
 (0)