Rename Transition#hasConstantLocation() to #isWeak() for clarity

Author: eregon

truffle/src/com.oracle.truffle.api.object/src/com/oracle/truffle/api/object/ShapeImpl.java

@@ -384,7 +384,7 @@ private static Object newTransitionMap(Transition firstTransition, ShapeImpl fir
     }
 
     private static ShapeImpl addToTransitionMap(Transition transition, ShapeImpl successor, TransitionMap<Transition, ShapeImpl> map) {
-        if (transition.hasConstantLocation()) {
+        if (transition.isWeak()) {
             return map.putWeakKeyIfAbsent(transition, successor);
         } else {
             return map.putIfAbsent(transition, successor);
@@ -416,7 +416,7 @@ private static boolean isTransitionMap(Object trans) {
     private static Object newSingleEntry(Transition transition, ShapeImpl successor) {
         transitionSingleEntriesCreated.inc();
         Object key = transition;
-        if (transition.hasConstantLocation()) {
+        if (transition.isWeak()) {
             key = new WeakKey<>(transition);
         }
         return new StrongKeyWeakValueEntry<>(key, successor);

truffle/src/com.oracle.truffle.api.object/src/com/oracle/truffle/api/object/Transition.java

@@ -69,7 +69,7 @@ public boolean equals(Object obj) {
 
     public abstract boolean isDirect();
 
-    protected boolean hasConstantLocation() {
+    protected boolean isWeak() {
         return false;
     }
 
@@ -127,7 +127,7 @@ public int getPropertyFlags() {
         }
 
         @Override
-        protected boolean hasConstantLocation() {
+        protected boolean isWeak() {
             return getProperty().getLocation().isConstant();
         }
     }
@@ -296,7 +296,7 @@ public String toString() {
         }
 
         @Override
-        protected boolean hasConstantLocation() {
+        protected boolean isWeak() {
             return getPropertyBefore().getLocation().isConstant() || getPropertyAfter().getLocation().isConstant();
         }
     }