Skip to content

Commit 889e421

Browse files
author
Andrija Kolic
committed
Copy 'rss' and 'latency' Barista datapoints into 'rss-distribution' and 'latency-distribution', respectively.
1 parent a8c6b61 commit 889e421

File tree

3 files changed

+20
-2
lines changed

3 files changed

+20
-2
lines changed

common.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"Jsonnet files should not include this file directly but use ci/common.jsonnet instead."
55
],
66

7-
"mx_version": "7.55.5",
7+
"mx_version": "7.55.6",
88

99
"COMMENT.jdks": "When adding or removing JDKs keep in sync with JDKs in ci/common.jsonnet",
1010
"jdks": {

sdk/mx.sdk/mx_sdk_benchmark.py

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3026,11 +3026,29 @@ def validateStdoutWithDimensions(self, out, benchmarks, bmSuiteArgs, retcode=Non
30263026
def computeDerivedDatapoints(self, datapoints: DataPoints) -> DataPoints:
30273027
"""Adds derived datapoints to the list of datapoints captured from the benchmark stdout or generated files.
30283028
Adds datapoints such as:
3029+
* rss-distribution: copies of rss datapoints, naming more clearly indicates that the metric comprises the
3030+
distribution represented by percentile values
3031+
* latency-distribution: copies of latency datapoints, naming more clearly indicates that the metric comprises
3032+
the distribution represented by percentile values
30293033
* max-rss: copied from specific rss percentile values
30303034
* time-to-first-response: copied from response_time with iteration 0
30313035
* max-time: copied from response_time with the highest value
30323036
* ops-per-GB-second: computed as throughput divided by max-rss
30333037
"""
3038+
# rss-distribution
3039+
rss_dps = filter(lambda dp: dp["metric.name"] == "rss", datapoints)
3040+
for rss_dp in rss_dps:
3041+
rss_dp_copy = rss_dp.copy()
3042+
rss_dp_copy["metric.name"] = "rss-distribution"
3043+
datapoints.append(rss_dp_copy)
3044+
3045+
# latency-distribution
3046+
latency_dps = filter(lambda dp: dp["metric.name"] == "latency", datapoints)
3047+
for latency_dp in latency_dps:
3048+
latency_dp_copy = latency_dp.copy()
3049+
latency_dp_copy["metric.name"] = "latency-distribution"
3050+
datapoints.append(latency_dp_copy)
3051+
30343052
# max-rss
30353053
percentile_to_copy_into_max_rss = float(mx_benchmark.RssPercentilesTracker.MaxRssCopyRule.percentile_to_copy_into_max_rss)
30363054
rss_dp_to_copy_from = next(filter(lambda dp: dp["metric.name"] == "rss" and dp["metric.percentile"] == percentile_to_copy_into_max_rss, datapoints), None)

sdk/mx.sdk/suite.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
# SOFTWARE.
4040
#
4141
suite = {
42-
"mxversion": "7.55.2",
42+
"mxversion": "7.55.6",
4343
"name" : "sdk",
4444
"version" : "26.0.0",
4545
"release" : False,

0 commit comments

Comments
 (0)