Skip to content

Commit a034fdd

Browse files
Avoid usage of TruffleLogger in espresso.classfile
1 parent 9377b7b commit a034fdd

File tree

4 files changed

+12
-13
lines changed

4 files changed

+12
-13
lines changed

espresso-shared/src/com.oracle.truffle.espresso.classfile/src/com/oracle/truffle/espresso/classfile/perf/DebugTimer.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,9 @@
2727
import java.util.ArrayList;
2828
import java.util.List;
2929
import java.util.concurrent.atomic.AtomicLong;
30+
import java.util.function.Consumer;
3031
import java.util.function.Supplier;
3132

32-
import com.oracle.truffle.api.TruffleLogger;
3333
import com.oracle.truffle.espresso.classfile.descriptors.ErrorUtil;
3434

3535
public final class DebugTimer {
@@ -90,7 +90,7 @@ public boolean equals(Object obj) {
9090
abstract static class DebugTimerImpl {
9191
abstract void tick(long tick);
9292

93-
abstract void report(TruffleLogger logger, String name);
93+
abstract void report(Consumer<String> logger, String name);
9494

9595
abstract void enter();
9696
}
@@ -114,11 +114,11 @@ void tick(long tick) {
114114
}
115115

116116
@Override
117-
void report(TruffleLogger logger, String name) {
117+
void report(Consumer<String> logger, String name) {
118118
if (counter.get() == 0) {
119-
logger.info(name + ": " + 0);
119+
logger.accept(name + ": " + 0);
120120
} else {
121-
logger.info(name + " total : " + getAsMillis(total()) + " | avg : " + getAsMillis(avg()));
121+
logger.accept(name + " total : " + getAsMillis(total()) + " | avg : " + getAsMillis(avg()));
122122
}
123123
}
124124

espresso-shared/src/com.oracle.truffle.espresso.classfile/src/com/oracle/truffle/espresso/classfile/perf/TimerCollection.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
*/
2525
package com.oracle.truffle.espresso.classfile.perf;
2626

27-
import com.oracle.truffle.api.TruffleLogger;
27+
import java.util.function.Consumer;
2828

2929
public abstract class TimerCollection {
3030
private static final TimerCollection NO_TIMER = new TimerCollectionImpl.NoTimer();
@@ -37,7 +37,7 @@ public static TimerCollection create(boolean enabled) {
3737
}
3838
}
3939

40-
public abstract void report(TruffleLogger logger);
40+
public abstract void report(Consumer<String> logger);
4141

4242
abstract DebugCloseable scope(DebugTimer timer);
4343
}

espresso-shared/src/com.oracle.truffle.espresso.classfile/src/com/oracle/truffle/espresso/classfile/perf/TimerCollectionImpl.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,7 @@
2828
import java.util.Map;
2929
import java.util.Set;
3030
import java.util.concurrent.ConcurrentHashMap;
31-
32-
import com.oracle.truffle.api.TruffleLogger;
31+
import java.util.function.Consumer;
3332

3433
class TimerCollectionImpl extends TimerCollection {
3534
private Map<DebugTimer, DebugTimer.DebugTimerImpl> mapping = new ConcurrentHashMap<>();
@@ -49,12 +48,12 @@ DebugCloseable scope(DebugTimer timer) {
4948
}
5049

5150
@Override
52-
public void report(TruffleLogger logger) {
51+
public void report(Consumer<String> logger) {
5352
Set<DebugTimer> visited = new HashSet<>();
5453
report(mapping.keySet(), logger, visited, "");
5554
}
5655

57-
private void report(Iterable<DebugTimer> timers, TruffleLogger logger, Set<DebugTimer> visited, String prefix) {
56+
private void report(Iterable<DebugTimer> timers, Consumer<String> logger, Set<DebugTimer> visited, String prefix) {
5857
for (DebugTimer timer : timers) {
5958
if (shouldProcess(visited, timer)) {
6059
visited.add(timer);
@@ -86,7 +85,7 @@ DebugCloseable scope(DebugTimer timer) {
8685
}
8786

8887
@Override
89-
public void report(TruffleLogger logger) {
88+
public void report(Consumer<String> logger) {
9089
}
9190
}
9291
}

espresso/src/com.oracle.truffle.espresso/src/com/oracle/truffle/espresso/runtime/EspressoShutdownHandler.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,7 @@ private void teardown() {
277277
}
278278
}
279279

280-
getContext().getTimers().report(getContext().getLogger());
280+
getContext().getTimers().report(getContext().getLogger()::info);
281281
}
282282

283283
/**

0 commit comments

Comments
 (0)