Skip to content

Commit af5935c

Browse files
committed
[GR-65319] Fix arguments validation in FileSizeBenchmarkSuite
PullRequest: graal/20906
2 parents 073cbf6 + 2203972 commit af5935c

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

vm/ci/ci_common/common.jsonnet

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -544,7 +544,7 @@ local devkits = graal_common.devkits;
544544
+ $.deploy_standalones(self.os, self.tags)
545545
+ (
546546
if (record_file_sizes) then [
547-
$.mx_vm_complete + $.record_file_sizes + ['--', 'standalones'],
547+
$.mx_vm_complete + $.record_file_sizes + ['--', '--', 'standalones'],
548548
$.upload_file_sizes,
549549
] else []
550550
),

vm/mx.vm/mx_vm_benchmark.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -362,10 +362,11 @@ def runAndReturnStdOut(self, benchmarks, bmSuiteArgs):
362362
def get_size_message(image_name, image_location):
363363
return FileSizeBenchmarkSuite.SZ_MSG_PATTERN.format(image_name, getsize(image_location), image_location)
364364

365-
bmSuiteArgs = bmSuiteArgs or ['base']
365+
runArgs = self.runArgs(bmSuiteArgs)
366+
runArgs = runArgs or ['base']
366367
out = ""
367368

368-
for arg in bmSuiteArgs:
369+
for arg in runArgs:
369370
if arg == 'standalones':
370371
# Standalones
371372
for project in mx.projects():
@@ -383,7 +384,7 @@ def get_size_message(image_name, image_location):
383384
launcher_name = mx_sdk_vm_impl.remove_exe_suffix(basename(location))
384385
out += get_size_message(launcher_name, os.path.join(output_root, location))
385386
else:
386-
mx.abort("FileSizeBenchmarkSuite expects 'base' or 'standalones' in bench suite arguments but got " + arg)
387+
mx.abort("FileSizeBenchmarkSuite expects 'base' (default) or 'standalones' in runArgs but got " + arg)
387388

388389
if out:
389390
mx.log(out, end='')

0 commit comments

Comments
 (0)