Skip to content

Commit b391aa5

Browse files
committed
Fix javadoc was guaranteeing non null message, but could be null if host exception message was null.
1 parent 645d27a commit b391aa5

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

sdk/src/org.graalvm.polyglot/src/org/graalvm/polyglot/PolyglotException.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ public StackTraceElement[] getStackTrace() {
173173
/**
174174
* Gets a user readable message for the polyglot exception. In case the exception is
175175
* {@link #isInternalError() internal} then the original java class name is included in the
176-
* message. The message never returns <code>null</code>.
176+
* message. The message may return <code>null</code> if no message is available.
177177
*
178178
* @since 19.0
179179
*/

truffle/CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,11 @@ This changelog summarizes major changes between Truffle versions relevant to lan
1818
* Added `ThreadLocalAction#notifyBlocked(Access)` and `ThreadLocalAction#notifyUnblocked(Access)` to notify thread local actions that their processing has been blocked/unblocked due to a blocked call (see `ThreadLocalAction` documentation).
1919
* `TruffleSafepoint#poll(Node)` does not require a non-null location anymore. However, it is still recommended to always pass a location node, if available.
2020
* GR-59565 Added `RootNode.prepareForCompilation` which allows root nodes to offload expensive computation to the compiler thread and to delay compilation if they are not yet fully profiled.
21+
* GR-58550 Added `FrameDescriptor.Builder.illegalDefaultValue()` which enables sets all frame slots as illegal before they were written. Before by default frame slots were initialized with the default value or `null`.
22+
GR-58550 Added `FrameDescriptor.Builder.illegalDefaultValue()` which initializes all frame slots as `FrameSlotKind.Illegal` for newly created frames. This is different from the default behavior, which initializes all frame slot kinds as `FrameSlotKind.Object`. This means that frame slots, when they are read before they were written, throw a `FrameSlotTypeException`, consistent with the behavior after clearing a frame slot.
23+
* GR-58550 Added `FrameDescriptor.Builder.addSlots(int)` which allows to allocate slots without reserving space for the tags. This is useful if a language manages its own cached tags, so no tag space is wasted.
24+
* GR-58550 Deprecated the default constructor for `FrameSlotTypeException` and replaced it with `FrameSlotTypeException.create(...)`. Exceptions of this kind thrown by the `Frame` now contain the slot index and the expected and the actual frame slot kind which are accessible with the respective instance methods.
25+
* GR-58550 Fixed invalid `PolyglotExcetion.getMessage()` javadoc. A polyglot exception may in fact return a `null` message.
2126

2227

2328
* GR-54760 `RootNode.translateStackTraceElement()` is now always consulted for polyglot and debugger stack traces. Stack traces now use the source section, the executable name, and the name of the declared meta-object to build `StackTraceElement` instances.

0 commit comments

Comments
 (0)