[GR-59640] Add IOException checked exception to InternalResource.versionHash(Env).

PullRequest: graal/19237

Author: chumer

truffle/CHANGELOG.md

@@ -12,6 +12,7 @@ This changelog summarizes major changes between Truffle versions relevant to lan
 * GR-57817 Java Native access for [JEP-472](https://openjdk.org/jeps/472) is now automatically provided for all languages and tools by Truffle. For more information, refer to the [GraalVM SDK Changelog](https://github.com/oracle/graal/blob/master/sdk/CHANGELOG.md).
 * GR-46292 The deprecated `TruffleInstrument.Provider` and `TruffleLanguage.Provider` interfaces, deprecated since version 23.1, have now been removed. They are replaced by the `com.oracle.truffle.api.provider.TruffleLanguageProvider` and `com.oracle.truffle.api.instrumentation.provider.TruffleInstrumentProvider` interfaces. The implementations of these interfaces are automatically generated by the annotation processor and this change requires no source code modifications, only recompilation.
 * GR-46293 The deprecated `com.oracle.truffle.api.library.DefaultExportProvider` and `com.oracle.truffle.api.library.EagerExportProvider` interfaces, deprecated since version 23.1, have now been removed. They are replaced by the `com.oracle.truffle.api.library.provider.DefaultExportProvider` and `com.oracle.truffle.api.library.provider.EagerExportProvider` interfaces. The implementations of these interfaces are automatically generated by the annotation processor and this change requires no source code modifications, only recompilation.
+* GR-59640 `InternalResource.versionHash(Env)` may now throw an `IOException` to indicate problems when reading the version from disk.
 
 
 ## Version 24.1.0

truffle/src/com.oracle.truffle.api/snapshot.sigtest

@@ -168,7 +168,7 @@ innr public abstract interface static !annotation Id
 innr public final static !enum CPUArchitecture
 innr public final static !enum OS
 innr public final static Env
-meth public abstract java.lang.String versionHash(com.oracle.truffle.api.InternalResource$Env)
+meth public abstract java.lang.String versionHash(com.oracle.truffle.api.InternalResource$Env) throws java.io.IOException
 meth public abstract void unpackFiles(com.oracle.truffle.api.InternalResource$Env,java.nio.file.Path) throws java.io.IOException
 
 CLSS public final static !enum com.oracle.truffle.api.InternalResource$CPUArchitecture

truffle/src/com.oracle.truffle.api/src/com/oracle/truffle/api/InternalResource.java

@@ -142,7 +142,7 @@ public interface InternalResource {
      *
      * @since 23.1
      */
-    String versionHash(Env env);
+    String versionHash(Env env) throws IOException;
 
     /**
      * Access to common utilities for unpacking resource files.

truffle/src/com.oracle.truffle.nfi.backend.libffi/src/com/oracle/truffle/nfi/backend/libffi/LibNFIResource.java

@@ -40,12 +40,11 @@
  */
 package com.oracle.truffle.nfi.backend.libffi;
 
-import com.oracle.truffle.api.CompilerDirectives;
-import com.oracle.truffle.api.InternalResource;
-
 import java.io.IOException;
 import java.nio.file.Path;
 
+import com.oracle.truffle.api.InternalResource;
+
 @InternalResource.Id(LibNFIResource.ID)
 final class LibNFIResource implements InternalResource {
 
@@ -63,13 +62,9 @@ public void unpackFiles(Env env, Path targetDirectory) throws IOException {
     }
 
     @Override
-    public String versionHash(Env env) {
-        try {
-            Path base = basePath(env);
-            return env.readResourceLines(base.resolve("sha256")).get(0);
-        } catch (IOException ioe) {
-            throw CompilerDirectives.shouldNotReachHere(ioe);
-        }
+    public String versionHash(Env env) throws IOException {
+        Path base = basePath(env);
+        return env.readResourceLines(base.resolve("sha256")).get(0);
     }
 
     private static Path basePath(Env env) {

truffle/src/com.oracle.truffle.polyglot/src/com/oracle/truffle/polyglot/JDKSupport.java

@@ -726,13 +726,9 @@ public void unpackFiles(Env env, Path targetDirectory) throws IOException {
         }
 
         @Override
-        public String versionHash(Env env) {
-            try {
-                Path base = basePath(env);
-                return env.readResourceLines(base.resolve("sha256")).get(0);
-            } catch (IOException ioe) {
-                throw new InternalError(ioe);
-            }
+        public String versionHash(Env env) throws IOException {
+            Path base = basePath(env);
+            return env.readResourceLines(base.resolve("sha256")).get(0);
         }
 
         private static Path basePath(Env env) {