Skip to content

Commit d5d9ae2

Browse files
committed
Remove vm_common.{sulong,truffleruby,graalpy,wasm,svm_common}
* And use common.deps instead. * Also removed ruby_vm_build and ruby_python_vm_build which are unused.
1 parent 19d6503 commit d5d9ae2

File tree

5 files changed

+16
-31
lines changed

5 files changed

+16
-31
lines changed

vm/ci/ci_common/common-bench.jsonnet

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ local repo_config = import '../../../ci/repo-configuration.libsonnet';
2323

2424
vm_bench_common: self.vm_bench_base(machine_name='x52') + { capabilities+: ['tmpfs25g'] },
2525

26-
vm_bench_js_linux_amd64(bench_suite=null): vm.vm_java_Latest + vm_common.svm_common + vm_common.sulong + vm.custom_vm + self.vm_bench_common + {
26+
vm_bench_js_linux_amd64(bench_suite=null): vm.vm_java_Latest + common.deps.svm + common.deps.sulong + vm.custom_vm + self.vm_bench_common + {
2727
cmd_base:: vm_common.mx_vm_common + ['--dynamicimports', 'js-benchmarks', 'benchmark', '--results-file', self.result_file],
2828
config_base:: ['--js-vm=graal-js', '--js-vm-config=default', '--jvm=graalvm-${VM_ENV}'],
2929
setup+: [
@@ -59,7 +59,7 @@ local repo_config = import '../../../ci/repo-configuration.libsonnet';
5959
base_cmd:: ['mx', '--env', env, '--dy', 'polybenchmarks'],
6060
},
6161

62-
vm_bench_polybenchmarks_linux_build: vm_common.svm_common + vm_common.truffleruby + vm_common.graalpy + vm.custom_vm + vm.vm_java_Latest + self.polybench_hpc_linux_common(shape='e4_36_256') + self.vm_bench_polybenchmarks_base(env='polybench-${VM_ENV}') + {
62+
vm_bench_polybenchmarks_linux_build: common.deps.svm + common.deps.truffleruby + common.deps.graalpy + vm.custom_vm + vm.vm_java_Latest + self.polybench_hpc_linux_common(shape='e4_36_256') + self.vm_bench_polybenchmarks_base(env='polybench-${VM_ENV}') + {
6363
setup+: [
6464
self.base_cmd + ['sforceimports'],
6565
],
@@ -80,7 +80,7 @@ local repo_config = import '../../../ci/repo-configuration.libsonnet';
8080
},
8181

8282
# TODO (GR-60584): re-enable espresso polybench jobs once polybench is unchained
83-
vm_bench_polybenchmarks_linux_common(vm_config='jvm', is_gate=false, suite='default:~r[.*jar]', shape=null): vm_common.svm_common + vm_common.truffleruby + vm.custom_vm + vm.vm_java_Latest + self.polybench_hpc_linux_common(shape=shape) + self.vm_bench_polybenchmarks_base(env='polybench-${VM_ENV}') {
83+
vm_bench_polybenchmarks_linux_common(vm_config='jvm', is_gate=false, suite='default:~r[.*jar]', shape=null): common.deps.svm + common.deps.truffleruby + vm.custom_vm + vm.vm_java_Latest + self.polybench_hpc_linux_common(shape=shape) + self.vm_bench_polybenchmarks_base(env='polybench-${VM_ENV}') {
8484
bench_cmd:: self.base_cmd + ['benchmark', '--results-file', self.result_file],
8585
setup+: [
8686
self.base_cmd + ['sforceimports'],
@@ -106,7 +106,7 @@ local repo_config = import '../../../ci/repo-configuration.libsonnet';
106106
timelimit: if (is_gate) then '1:00:00' else '1:30:00',
107107
} + (if is_gate then self.vm_bench_base(machine_name=null) else self.vm_bench_common),
108108

109-
vm_bench_polybench_linux_common(env='polybench-${VM_ENV}', fail_fast=false, skip_machine=false): (if skip_machine then self.vm_bench_base(machine_name=null) else self.vm_bench_common) + vm_common.svm_common + vm_common.truffleruby + vm_common.graalpy + vm.custom_vm + vm_common.wasm {
109+
vm_bench_polybench_linux_common(env='polybench-${VM_ENV}', fail_fast=false, skip_machine=false): (if skip_machine then self.vm_bench_base(machine_name=null) else self.vm_bench_common) + common.deps.svm + common.deps.truffleruby + common.deps.graalpy + common.deps.wasm + vm.custom_vm {
110110
base_cmd:: ['mx', '--env', env],
111111
bench_cmd:: self.base_cmd + ['benchmark'] + (if (fail_fast) then ['--fail-fast'] else []),
112112
interpreter_bench_cmd(vmConfig):: self.bench_cmd +
@@ -275,7 +275,7 @@ local repo_config = import '../../../ci/repo-configuration.libsonnet';
275275
notify_groups:: ['compiler_bench']
276276
},
277277

278-
vm_bench_polybench_nfi_linux_amd64: self.vm_bench_common + vm_common.svm_common + self.vm_bench_polybench_nfi,
278+
vm_bench_polybench_nfi_linux_amd64: self.vm_bench_common + common.deps.svm + self.vm_bench_polybench_nfi,
279279

280280
local builds = [
281281
# We used to expand `${common_vm_linux}` here to work around some limitations in the version of pyhocon that we use in the CI

vm/ci/ci_common/common.jsonnet

Lines changed: 5 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -73,24 +73,12 @@ local devkits = graal_common.devkits;
7373
},
7474
},
7575

76-
# SULONG
77-
sulong: graal_common.deps.sulong,
78-
79-
# TRUFFLERUBY, needs OpenSSL 1.0.2+, so OracleLinux 7+
80-
truffleruby: graal_common.deps.sulong + graal_common.deps.truffleruby,
81-
8276
fastr_no_recommended: {
8377
environment+: {
8478
FASTR_NO_RECOMMENDED: 'true'
8579
},
8680
},
8781

88-
# GRAALPYTHON
89-
graalpy: self.sulong + graal_common.deps.graalpy,
90-
91-
# WASM
92-
wasm: graal_common.deps.wasm,
93-
9482
vm_linux_amd64_common: graal_common.deps.svm {
9583
capabilities+: ['manycores', 'ram16gb', 'fast'],
9684
},
@@ -146,8 +134,7 @@ local devkits = graal_common.devkits;
146134
mx_vm_complete: vm.mx_cmd_base_no_env + ['--env', '${VM_ENV}-complete'] + self.mx_vm_cmd_suffix,
147135

148136
// svm_common includes the dependencies for all platforms besides windows amd64
149-
svm_common: graal_common.deps.svm,
150-
svm_common_windows_amd64(jdk): self.svm_common + graal_common.devkits["windows-jdk" + jdk],
137+
svm_common_windows_amd64(jdk): graal_common.deps.svm + graal_common.devkits["windows-jdk" + jdk],
151138

152139
maven_deploy_sdk: ['--suite', 'sdk', 'maven-deploy', '--validate', 'none', '--all-distribution-types', '--with-suite-revisions-metadata'],
153140
deploy_artifacts_sdk(os, base_dist_name=null): (if base_dist_name != null then ['--base-dist-name=' + base_dist_name] else []) + ['--suite', 'sdk', 'deploy-artifacts', '--uploader', if os == 'windows' then 'artifact_uploader.cmd' else 'artifact_uploader'],
@@ -176,9 +163,7 @@ local devkits = graal_common.devkits;
176163
$.mx_vm_complete + self.artifact_deploy_standalones_dry_run(os)
177164
],
178165

179-
ruby_vm_build: self.svm_common + self.sulong + self.truffleruby + vm.custom_vm,
180-
ruby_python_vm_build: self.ruby_vm_build + self.graalpy,
181-
full_vm_build: self.ruby_python_vm_build + graal_common.deps.fastr,
166+
full_vm_build: graal_common.deps.svm + graal_common.deps.sulong + graal_common.deps.truffleruby + graal_common.deps.graalpy + graal_common.deps.fastr + vm.custom_vm,
182167

183168
graalvm_complete_build_deps(edition, os, arch, java_version):
184169
local java_deps(edition) = {
@@ -201,7 +186,7 @@ local devkits = graal_common.devkits;
201186
if (os == 'windows') then
202187
if (arch == 'amd64') then
203188
# Windows/AMD64
204-
java_deps(edition) + (if (java_version == 'latest') then self.svm_common_windows_amd64("Latest") else self.svm_common_windows_amd64(java_version)) + self.js_windows_common + self.sulong
189+
java_deps(edition) + (if (java_version == 'latest') then self.svm_common_windows_amd64("Latest") else self.svm_common_windows_amd64(java_version)) + self.js_windows_common + graal_common.deps.sulong
205190
else
206191
error 'Unknown windows arch: ' + arch
207192
else if (os == 'linux' || os == 'darwin') then
@@ -567,9 +552,9 @@ local devkits = graal_common.devkits;
567552
# Darwin/AARCH64
568553
deploy_vm_standalones_javaLatest_darwin_aarch64: vm.vm_java_Latest + self.full_vm_build + self.darwin_deploy + self.vm_base('darwin', 'aarch64', 'daily', deploy=true) + self.deploy_graalvm_standalones('latest') + {name: 'daily-deploy-vm-standalones-java-latest-darwin-aarch64', notify_groups:: ["deploy"], notify_emails+: ["[email protected]"], timelimit: '3:00:00'},
569554
# Windows/AMD64
570-
deploy_vm_standalones_javaLatest_windows_amd64: vm.vm_java_Latest + self.svm_common_windows_amd64('Latest') + self.js_windows_common + self.sulong + self.vm_base('windows', 'amd64', 'daily', deploy=true, jdk_hint='Latest') + self.deploy_graalvm_standalones('latest') + self.deploy_build + {name: 'daily-deploy-vm-standalones-java-latest-windows-amd64', timelimit: '2:30:00', notify_groups:: ["deploy"]},
555+
deploy_vm_standalones_javaLatest_windows_amd64: vm.vm_java_Latest + self.svm_common_windows_amd64('Latest') + self.js_windows_common + graal_common.deps.sulong + self.vm_base('windows', 'amd64', 'daily', deploy=true, jdk_hint='Latest') + self.deploy_graalvm_standalones('latest') + self.deploy_build + {name: 'daily-deploy-vm-standalones-java-latest-windows-amd64', timelimit: '2:30:00', notify_groups:: ["deploy"]},
571556

572-
local sulong_vm_tests = self.svm_common + self.sulong + vm.custom_vm + self.vm_base('linux', 'amd64', 'gate') + {
557+
local sulong_vm_tests = graal_common.deps.svm + graal_common.deps.sulong + vm.custom_vm + self.vm_base('linux', 'amd64', 'gate') + {
573558
run: [
574559
['export', 'SVM_SUITE=' + vm.svm_suite],
575560
['mx', '--dynamicimports', '$SVM_SUITE,/sulong', '--disable-polyglot', '--disable-libpolyglot', 'gate', '--no-warning-as-error', '--tags', 'build,sulong'],

vm/ci/ci_common/libgraal.jsonnet

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ local galahad = import '../../../ci/ci_common/galahad-common.libsonnet';
107107
if (os_arch == 'windows-amd64') then
108108
c.svm_common_windows_amd64(jdk)
109109
else
110-
c.svm_common,
110+
graal_common.deps.svm,
111111

112112
local all_os_arches = [
113113
"linux-amd64",

vm/ci/ci_includes/vm-native.jsonnet

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ local vm_common = import '../ci_common/common.jsonnet';
44
local graal_common = import '../../../ci/ci_common/common.jsonnet';
55

66
{
7-
local truffle_native_tck = vm_common.svm_common + {
7+
local truffle_native_tck = graal_common.deps.svm + {
88
run+: [
99
['mx', '--env', 'ce', '--dynamicimports', '/tools', '--native-images=lib:jvmcicompiler', 'gate', '--tags', 'build,truffle-native-tck,truffle-native-tck-sl'],
1010
],
@@ -14,7 +14,7 @@ local graal_common = import '../../../ci/ci_common/common.jsonnet';
1414
name: self.targets[0] + '-vm-truffle-native-tck-labs' + self.jdk_name + '-linux-amd64',
1515
},
1616

17-
local truffle_native_tck_wasm = vm_common.svm_common + {
17+
local truffle_native_tck_wasm = graal_common.deps.svm + {
1818
run+: [
1919
['mx', '--env', 'ce', '--dynamicimports', '/wasm', '--native-images=lib:jvmcicompiler', 'gate', '--tags', 'build,truffle-native-tck-wasm'],
2020
],
@@ -24,7 +24,7 @@ local graal_common = import '../../../ci/ci_common/common.jsonnet';
2424
name: self.targets[0] + '-vm-truffle-native-tck-wasm-labs' + self.jdk_name + '-linux-amd64',
2525
},
2626

27-
local truffle_maven_downloader = vm_common.svm_common + vm_common.sulong + {
27+
local truffle_maven_downloader = graal_common.deps.svm + graal_common.deps.sulong + {
2828
run+: [
2929
['export', 'SVM_SUITE=' + vm.svm_suite],
3030
['mx', '--env', 'ce-llvm', '--native-images=', 'gate', '--no-warning-as-error', '--tags', 'build,maven-downloader'],
@@ -39,7 +39,7 @@ local graal_common = import '../../../ci/ci_common/common.jsonnet';
3939
},
4040

4141
local builds = [
42-
vm.vm_java_Latest + vm_common.svm_common + vm_common.sulong + vm_common.graalpy + vm.custom_vm + vm_common.vm_base('linux', 'amd64', 'gate') + {
42+
vm.vm_java_Latest + graal_common.deps.svm + graal_common.deps.sulong + graal_common.deps.graalpy + vm.custom_vm + vm_common.vm_base('linux', 'amd64', 'gate') + {
4343
run+: [
4444
['export', 'SVM_SUITE=' + vm.svm_suite],
4545
['mx', '--dynamicimports', '$SVM_SUITE,graalpython', '--disable-polyglot', '--disable-libpolyglot', '--force-bash-launchers=lli,native-image', 'gate', '--no-warning-as-error', '--tags', 'build,python'],

vm/ci/ci_includes/vm.jsonnet

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ local graal_common = import '../../../ci/ci_common/common.jsonnet';
118118
],
119119
name: 'gate-vm-unittest-windows-amd64',
120120
}, ["sdk", "truffle", "vm"]),
121-
self.vm_java_Latest + vm_common.vm_base('linux', 'amd64', 'gate') + vm_common.sulong + {
121+
self.vm_java_Latest + vm_common.vm_base('linux', 'amd64', 'gate') + graal_common.deps.sulong + {
122122
environment+: {
123123
DYNAMIC_IMPORTS: '/tools,/substratevm,/sulong',
124124
NATIVE_IMAGES: 'polyglot',

0 commit comments

Comments
 (0)