Skip to content

Commit d838152

Browse files
committed
[GR-63600] Fix missing optimization configs in benchmarks.
PullRequest: graal/20427
2 parents 56cebab + 5803013 commit d838152

File tree

2 files changed

+10
-11
lines changed

2 files changed

+10
-11
lines changed

sdk/mx.sdk/mx_sdk_benchmark.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -838,7 +838,7 @@ def _configure_from_name(self, config_name):
838838
rule = r'^(?P<native_architecture>native-architecture-)?(?P<string_inlining>string-inlining-)?(?P<otw>otw-)?(?P<compacting_gc>compacting-gc-)?(?P<preserve_all>preserve-all-)?(?P<preserve_classpath>preserve-classpath-)?' \
839839
r'(?P<future_defaults_all>future-defaults-all-)?(?P<gate>gate-)?(?P<upx>upx-)?(?P<quickbuild>quickbuild-)?(?P<gc>g1gc-)?' \
840840
r'(?P<llvm>llvm-)?(?P<pgo>pgo-|pgo-sampler-)?(?P<inliner>inline-)?' \
841-
r'(?P<analysis_context_sensitivity>insens-|allocsens-|1obj-|2obj1h-|3obj2h-|4obj3h-)?(?P<no_inlining_before_analysis>no-inline-)?(?P<jdk_profiles>jdk-profiles-collect-|adopted-jdk-pgo-)?' \
841+
r'(?P<analysis_context_sensitivity>insens-|allocsens-|1obj-|2obj1h-|3obj2h-|4obj3h-)?(?P<jdk_profiles>jdk-profiles-collect-|adopted-jdk-pgo-)?' \
842842
r'(?P<profile_inference>profile-inference-feature-extraction-|profile-inference-pgo-|profile-inference-debug-)?(?P<sampler>safepoint-sampler-|async-sampler-)?(?P<optimization_level>O0-|O1-|O2-|O3-|Os-)?(default-)?(?P<edition>ce-|ee-)?$'
843843

844844
mx.logv(f"== Registering configuration: {config_name}")

vm/mx.vm/mx_vm_benchmark.py

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -518,18 +518,17 @@ def register_graalvm_vms():
518518

519519
for short_name, config_suffix in [('niee', 'ee'), ('ni', 'ce')]:
520520
if any(component.short_name == short_name for component in mx_sdk_vm_impl.registered_graalvm_components(stage1=False)):
521+
config_names = list()
521522
for main_config in ['default', 'gate', 'llvm', 'native-architecture', 'future-defaults-all', 'preserve-all', 'preserve-classpath'] + analysis_context_sensitivity:
522-
final_config_name = f'{main_config}-{config_suffix}'
523-
mx_benchmark.add_java_vm(NativeImageVM('native-image', final_config_name, ['--add-exports=java.base/jdk.internal.misc=ALL-UNNAMED']), _suite, 10)
524-
# ' ' force the empty O<> configs as well
525-
for main_config in ['llvm', 'native-architecture', 'g1gc', 'native-architecture-g1gc', 'preserve-all', 'preserve-classpath'] + analysis_context_sensitivity:
526-
for optimization_level in optimization_levels:
527-
if len(main_config) > 0:
528-
final_config_name = f'{main_config}-{optimization_level}-{config_suffix}'
529-
else:
530-
final_config_name = f'{optimization_level}-{config_suffix}'
531-
mx_benchmark.add_java_vm(NativeImageVM('native-image', final_config_name, ['--add-exports=java.base/jdk.internal.misc=ALL-UNNAMED']), _suite, 10)
523+
config_names.append(f'{main_config}-{config_suffix}')
532524

525+
for optimization_level in optimization_levels:
526+
config_names.append(f'{optimization_level}-{config_suffix}')
527+
for main_config in ['llvm', 'native-architecture', 'g1gc', 'native-architecture-g1gc', 'preserve-all', 'preserve-classpath'] + analysis_context_sensitivity:
528+
config_names.append(f'{main_config}-{optimization_level}-{config_suffix}')
529+
530+
for config_name in config_names:
531+
mx_benchmark.add_java_vm(NativeImageVM('native-image', config_name, ['--add-exports=java.base/jdk.internal.misc=ALL-UNNAMED']), _suite, 10)
533532

534533
# Adding JAVA_HOME VMs to be able to run benchmarks on GraalVM binaries without the need of building it first
535534
for java_home_config in ['default', 'pgo', 'g1gc', 'g1gc-pgo', 'upx', 'upx-g1gc', 'quickbuild', 'quickbuild-g1gc']:

0 commit comments

Comments
 (0)