Remove deopt/boundary from executeUncached methods in Bytecode DSL

Author: DSouzaM

truffle/src/com.oracle.truffle.dsl.processor/src/com/oracle/truffle/dsl/processor/generator/FlatNodeGenFactory.java

@@ -2735,7 +2735,7 @@ public CodeExecutableElement createExecuteMethod(CodeTypeElement clazz, CodeExec
                     List<SpecializationData> specializations, boolean skipStateChecks) {
         final List<SpecializationData> allSpecializations = specializations;
         int signatureSize = node.getPolymorphicExecutable().getSignatureParameters().size();
-        ExecutableTypeData type = new ExecutableTypeData(node, baseMethod, signatureSize, List.of(node.getFrameType()), false);
+        ExecutableTypeData type = new ExecutableTypeData(node, baseMethod, signatureSize, List.of(node.getFrameType()), false, true);
 
         List<SpecializationData> implementedSpecializations = allSpecializations;
         CodeExecutableElement method = createExecuteMethod(type);
@@ -2838,20 +2838,19 @@ private CodeExecutableElement createUncachedExecute(ExecutableTypeData forType)
             effectiveEvaluatedCount++;
         }
 
-        boolean isExecutableInUncached = effectiveEvaluatedCount != node.getExecutionCount() && !node.getChildren().isEmpty();
-        if (!isExecutableInUncached) {
-            GeneratorUtils.addBoundaryOrTransferToInterpreter(method, builder);
-        }
-
         if (forType.getMethod() != null) {
             method.getModifiers().addAll(forType.getMethod().getModifiers());
             method.getModifiers().remove(Modifier.ABSTRACT);
         }
 
+        boolean isExecutableInUncached = effectiveEvaluatedCount != node.getExecutionCount() && !node.getChildren().isEmpty();
         if (isExecutableInUncached) {
             builder.tree(GeneratorUtils.createShouldNotReachHere("This execute method cannot be used for uncached node versions as it requires child nodes to be present. " +
                             "Use an execute method that takes all arguments as parameters."));
         } else {
+            if (forType.isReachableForRuntimeCompilation()) {
+                GeneratorUtils.addBoundaryOrTransferToInterpreter(method, builder);
+            }
             generateTraceOnEnterCall(builder, frameState);
             generateTraceOnExceptionStart(builder);
             SpecializationGroup group = SpecializationGroup.create(compatibleSpecializations);

truffle/src/com.oracle.truffle.dsl.processor/src/com/oracle/truffle/dsl/processor/model/ExecutableTypeData.java

@@ -70,6 +70,7 @@ public class ExecutableTypeData extends MessageContainer implements Comparable<E
     private String uniqueName;
 
     private final boolean ignoreUnexpected;
+    private final boolean reachableForRuntimeCompilation;
 
     public ExecutableTypeData(NodeData node, TypeMirror returnType, String uniqueName, TypeMirror frameParameter, List<TypeMirror> evaluatedParameters) {
         this.node = node;
@@ -79,14 +80,16 @@ public ExecutableTypeData(NodeData node, TypeMirror returnType, String uniqueNam
         this.uniqueName = uniqueName;
         this.method = null;
         this.ignoreUnexpected = false;
+        this.reachableForRuntimeCompilation = true;
     }
 
     @SuppressWarnings("this-escape")
-    public ExecutableTypeData(NodeData node, ExecutableElement method, int signatureSize, List<TypeMirror> frameTypes, boolean ignoreUnexpected) {
+    public ExecutableTypeData(NodeData node, ExecutableElement method, int signatureSize, List<TypeMirror> frameTypes, boolean ignoreUnexpected, boolean reachableForRuntimeCompilation) {
         this.node = node;
         this.method = method;
         this.returnType = method.getReturnType();
         this.ignoreUnexpected = ignoreUnexpected;
+        this.reachableForRuntimeCompilation = reachableForRuntimeCompilation;
         TypeMirror foundFrameParameter = null;
         List<? extends VariableElement> parameters = method.getParameters();
 
@@ -218,6 +221,10 @@ public int getEvaluatedCount() {
         return evaluatedParameters.size();
     }
 
+    public boolean isReachableForRuntimeCompilation() {
+        return reachableForRuntimeCompilation;
+    }
+
     public boolean canDelegateTo(ExecutableTypeData to) {
         ExecutableTypeData from = this;
         if (to.getEvaluatedCount() < from.getEvaluatedCount()) {

truffle/src/com.oracle.truffle.dsl.processor/src/com/oracle/truffle/dsl/processor/parser/NodeParser.java

@@ -2277,7 +2277,8 @@ private List<ExecutableTypeData> parseExecutableTypeData(NodeData node, List<? e
                 continue;
             }
             boolean ignoreUnexpected = mode == ParseMode.EXPORTED_MESSAGE;
-            ExecutableTypeData executableType = new ExecutableTypeData(node, method, signatureSize, context.getFrameTypes(), ignoreUnexpected);
+            boolean reachableForRuntimeCompilation = !(mode == ParseMode.OPERATION && node.isGenerateUncached());
+            ExecutableTypeData executableType = new ExecutableTypeData(node, method, signatureSize, context.getFrameTypes(), ignoreUnexpected, reachableForRuntimeCompilation);
 
             if (executableType.getFrameParameter() != null) {
                 boolean supportedType = false;