[GR-59669] Remove System.exit call from TruffleFromLibGraalEntryPoints.

PullRequest: graal/19262

Author: tzezula

truffle/src/com.oracle.truffle.runtime/src/com/oracle/truffle/runtime/hotspot/libgraal/LibGraalTruffleCompilationSupport.java

@@ -57,6 +57,15 @@
  */
 public final class LibGraalTruffleCompilationSupport implements TruffleCompilationSupport {
 
+    public LibGraalTruffleCompilationSupport() {
+        /*
+         * Eagerly verify TruffleFromLibGraalEntryPoints before creating the HotSpotTruffleRuntime.
+         * This ensures stack traces are captured without to/from native transitions and are
+         * generated by an application thread rather than a Truffle compiler thread.
+         */
+        assert TruffleFromLibGraalEntryPoints.checkHotSpotCalls();
+    }
+
     private volatile String cachedCompilerConfigurationName;
 
     public static void initializeIsolate(long isolateThreadId) {

truffle/src/com.oracle.truffle.runtime/src/com/oracle/truffle/runtime/hotspot/libgraal/TruffleFromLibGraalEntryPoints.java

@@ -85,7 +85,6 @@
 import static java.lang.System.lineSeparator;
 import static java.util.stream.Collectors.joining;
 
-import java.io.PrintStream;
 import java.lang.reflect.Method;
 import java.lang.reflect.Modifier;
 import java.net.URI;
@@ -130,10 +129,6 @@
  */
 final class TruffleFromLibGraalEntryPoints {
 
-    static {
-        assert checkHotSpotCalls();
-    }
-
     @TruffleFromLibGraal(Id.OnIsolateShutdown)
     static void onIsolateShutdown(long isolateId) {
         LibGraalIsolate.unregister(isolateId);
@@ -491,7 +486,7 @@ static Object getHostMethodInfo(Object truffleRuntime, long methodHandle) {
      * </ol>
      * </p>
      */
-    private static boolean checkHotSpotCalls() {
+    static boolean checkHotSpotCalls() {
         Set<Id> unimplemented = EnumSet.allOf(Id.class);
         Map<String, Id> entryPointMethodNames = unimplemented.stream().collect(Collectors.toMap(Id::getMethodName, (id) -> id));
         Map<Id, List<Method>> idToMethod = new LinkedHashMap<>();
@@ -549,13 +544,8 @@ private static String missingImpl(Id id) {
     private static void check(Id id, boolean condition, String format, Object... args) {
         if (!condition) {
             String msg = format(format, args);
-            PrintStream err = System.err;
-            if (id != null) {
-                err.printf("ERROR: %s.%s: %s%n", TruffleFromLibGraalEntryPoints.class.getName(), id, msg);
-            } else {
-                err.printf("ERROR: %s: %s%n", TruffleFromLibGraalEntryPoints.class.getName(), msg);
-            }
-            System.exit(99);
+            String target = id != null ? format("%s.%s", TruffleFromLibGraalEntryPoints.class.getName(), id) : TruffleFromLibGraalEntryPoints.class.getName();
+            throw new AssertionError(format("Incompatible Truffle runtime change: %s: %s", target, msg));
         }
     }
 }