Adopt HotSpot behavior in member name resolution when argument are non-standard.

Author: rakachan

espresso/src/com.oracle.truffle.espresso/src/com/oracle/truffle/espresso/substitutions/Target_java_lang_invoke_MethodHandleNatives.java

@@ -420,7 +420,7 @@ abstract static class ResolveNode extends SubstitutionNode {
         @JavaType(internalName = "Ljava/lang/invoke/MemberName;")
         StaticObject doCached(
                         @JavaType(internalName = "Ljava/lang/invoke/MemberName;") StaticObject memberName,
-                        @JavaType(value = Class.class) StaticObject caller,
+                        @JavaType(value = Class.class) StaticObject guestCaller,
                         @SuppressWarnings("unused") int lookupMode,
                         @Bind("getMeta()") Meta meta,
                         @Cached BranchProfile isMethodProfile,
@@ -448,18 +448,34 @@ StaticObject doCached(
                 throw meta.throwExceptionWithMessage(meta.java_lang_IllegalArgumentException, "Nothing to resolve.");
             }
             // Extract resolution information from member name.
-            Klass resolutionKlass = clazz.getMirrorKlass(meta);
             final int flags = meta.java_lang_invoke_MemberName_flags.getInt(memberName);
             if (Integer.bitCount(flags & ALL_KINDS) != 1) {
                 // Ensure the flags field is not ill-formed.
                 iaeProfile.enter();
                 throw meta.throwExceptionWithMessage(meta.java_lang_IllegalArgumentException, "Invalid MemberName flag format.");
             }
 
+            // Determine the holder klass
+            Klass resolutionKlass = clazz.getMirrorKlass(meta);
+            if (!(resolutionKlass instanceof ObjectKlass)) {
+                // Non-standard behavior: behave as HotSpot.
+                if (resolutionKlass.isArray()) {
+                    resolutionKlass = meta.java_lang_Object;
+                } else if (resolutionKlass.isPrimitive()) {
+                    throw defaultResolutionFailure(meta, flags);
+                }
+            }
+
+            // Determine caller klass
+            Klass callerKlass = StaticObject.isNull(guestCaller) ? null : guestCaller.getMirrorKlass(meta);
+            if (callerKlass != null && callerKlass.isPrimitive()) {
+                // HotSpot behavior: primitive caller klass skip checks.
+                callerKlass = null;
+            }
+
             EspressoContext ctx = meta.getContext();
             ByteSequence desc = asSignature(type, meta);
             Symbol<Name> name = lookupName(meta, meta.toHostString(guestName), (Constants.flagHas(flags, MN_IS_FIELD)) ? meta.java_lang_NoSuchFieldException : meta.java_lang_NoSuchMethodException);
-            ObjectKlass callerKlass = StaticObject.isNull(caller) ? null : (ObjectKlass) caller.getMirrorKlass(meta);
 
             boolean doAccessChecks = callerKlass != null;
             boolean doConstraintsChecks = (callerKlass != null && ((lookupMode & LM_UNCONDITIONAL) == 0));
@@ -511,6 +527,16 @@ StaticObject doCached(
             return memberName;
         }
 
+        private static RuntimeException defaultResolutionFailure(Meta meta, int flags) {
+            if (Constants.flagHas(flags, MN_IS_FIELD)) {
+                throw meta.throwExceptionWithMessage(meta.java_lang_NoSuchFieldError, "Field resolution failed");
+            } else if (Constants.flagHas(flags, MN_IS_METHOD) || Constants.flagHas(flags, MN_IS_CONSTRUCTOR)) {
+                throw meta.throwExceptionWithMessage(meta.java_lang_NoSuchMethodError, "Method resolution failed");
+            } else {
+                throw meta.throwExceptionWithMessage(meta.java_lang_LinkageError, "resolution failed");
+            }
+        }
+
         private static PolySigIntrinsics getPolysignatureIntrinsicID(BranchProfile isHandleMethodProfile, int flags, Klass resolutionKlass, int refKind, Symbol<Name> name) {
             PolySigIntrinsics mhMethodId = None;
             if (Constants.flagHas(flags, MN_IS_METHOD) &&