Return value of Object::Set() should not be ignored.

iamstolis · iamstolis · commit 04ebcd6336cc · 2022-09-29T19:44:38.000+02:00
diff --git a/graal-nodejs/src/util-inl.h b/graal-nodejs/src/util-inl.h
@@ -431,7 +431,7 @@ v8::MaybeLocal<v8::Value> ToV8Value(v8::Local<v8::Context> context,
   for (size_t i = 0; i < vec.size(); ++i) {
     if (!ToV8Value(context, vec[i], isolate).ToLocal(&item))
       return v8::MaybeLocal<v8::Value>();
-    array->Set(context, i, item);
+    array->Set(context, i, item).Check();
   }
 
   return handle_scope.Escape(array);

Original file line number	Diff line number	Diff line change
`@@ -431,7 +431,7 @@ v8::MaybeLocal<v8::Value> ToV8Value(v8::Local<v8::Context> context,`
`431`	`431`	`for (size_t i = 0; i < vec.size(); ++i) {`
`432`	`432`	`if (!ToV8Value(context, vec[i], isolate).ToLocal(&item))`
`433`	`433`	`return v8::MaybeLocal<v8::Value>();`
`434`		`- array->Set(context, i, item);`
	`434`	`+ array->Set(context, i, item).Check();`
`435`	`435`	`}`
`436`	`436`
`437`	`437`	`return handle_scope.Escape(array);`