[GR-31575] Implementation of Resizable and Growable ArrayBuffers proposal.

PullRequest: js/3158

Author: iamstolis

CHANGELOG.md

@@ -9,6 +9,7 @@ See [release calendar](https://www.graalvm.org/release-calendar/) for release da
 * Implemented the [Make eval-introduced global vars redeclarable](https://github.com/tc39/proposal-redeclarable-global-eval-vars) proposal.
 * Implemented the [Float16Array](https://github.com/tc39/proposal-float16array) proposal. It is available in ECMAScript staging mode (`--js.ecmascript-version=staging`).
 * Implemented the [Array.fromAsync](https://github.com/tc39/proposal-array-from-async) proposal. It is available in ECMAScript staging mode (`--js.ecmascript-version=staging`).
+* Implemented the [Resizable and Growable ArrayBuffers](https://github.com/tc39/proposal-resizablearraybuffer) proposal. It is available in ECMAScript staging mode (`--js.ecmascript-version=staging`).
 * Updated Node.js to version 20.13.1.
 
 ## Version 24.0.0

graal-js/src/com.oracle.truffle.js.test.external/src/com/oracle/truffle/js/test/external/test262/Test262Runnable.java

@@ -250,6 +250,7 @@ public class Test262Runnable extends TestRunnable {
                     "regexp-named-groups",
                     "regexp-unicode-property-escapes",
                     "regexp-v-flag",
+                    "resizable-arraybuffer",
                     "rest-parameters",
                     "set-methods",
                     "string-trimming",
@@ -265,7 +266,6 @@ public class Test262Runnable extends TestRunnable {
                     "IsHTMLDDA",
                     "explicit-resource-management",
                     "regexp-modifiers",
-                    "resizable-arraybuffer",
                     "tail-call-optimization",
     });
     private static final Set<String> STAGING_FEATURES = featureSet(new String[]{
@@ -282,6 +282,7 @@ public class Test262Runnable extends TestRunnable {
                     "decorators",
                     "json-parse-with-source",
                     "promise-with-resolvers",
+                    "resizable-arraybuffer",
     });
 
     public Test262Runnable(TestSuite suite, TestFile testFile) {

graal-js/src/com.oracle.truffle.js.test.external/src/com/oracle/truffle/js/test/external/testv8/TestV8Runnable.java

@@ -93,7 +93,6 @@ public class TestV8Runnable extends TestRunnable {
                     "--experimental-wasm-stringref",
                     "--experimental-wasm-type-reflection",
                     "--expose-fast-api",
-                    "--harmony-rab-gsab",
                     "--harmony-struct",
                     "--wasm-test-streaming"
     });
@@ -103,6 +102,7 @@ public class TestV8Runnable extends TestRunnable {
                     "--harmony-array-grouping",
                     "--harmony-intl-locale-info-func",
                     "--harmony-json-parse-with-source",
+                    "--harmony-rab-gsab",
                     "--harmony-shadow-realm",
                     "--harmony-weak-refs-with-cleanup-some",
                     "--js-promise-withresolvers",

graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/builtins/ArrayBufferPrototypeBuiltins.java

@@ -126,7 +126,7 @@ protected JSObject doArrayIterator(VirtualFrame frame, JSArrayIteratorObject ite
             long length;
             if (isTypedArrayProfile.profile(this, JSArrayBufferView.isJSArrayBufferView(array))) {
                 JSTypedArrayObject typedArray = (JSTypedArrayObject) array;
-                if (JSArrayBufferView.hasDetachedBuffer(typedArray, getContext())) {
+                if (JSArrayBufferView.isOutOfBounds(typedArray, getContext())) {
                     errorBranch.enter(this);
                     throw Errors.createTypeError("Cannot perform Array Iterator.prototype.next on a detached ArrayBuffer");
                 }

graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/builtins/ArrayIteratorPrototypeBuiltins.java

@@ -432,10 +432,10 @@ protected final ArraySpeciesConstructorNode getArraySpeciesConstructorNode() {
             return arraySpeciesCreateNode;
         }
 
-        protected final void checkHasDetachedBuffer(JSDynamicObject view) {
-            if (JSArrayBufferView.hasDetachedBuffer(view, getContext())) {
+        protected final void checkOutOfBounds(JSTypedArrayObject view) {
+            if (JSArrayBufferView.isOutOfBounds(view, getContext())) {
                 errorBranch.enter();
-                throw Errors.createTypeErrorDetachedBuffer();
+                throw Errors.createTypeErrorOutOfBoundsTypedArray();
             }
         }
 
@@ -448,9 +448,9 @@ protected final JSTypedArrayObject validateTypedArray(Object obj) {
                 throw Errors.createTypeErrorArrayBufferViewExpected();
             }
             JSTypedArrayObject typedArrayObject = (JSTypedArrayObject) obj;
-            if (JSArrayBufferView.hasDetachedBuffer(typedArrayObject, getContext())) {
+            if (JSArrayBufferView.isOutOfBounds(typedArrayObject, getContext())) {
                 errorBranch.enter();
-                throw Errors.createTypeErrorDetachedBuffer();
+                throw Errors.createTypeErrorOutOfBoundsTypedArray();
             }
             return typedArrayObject;
         }
@@ -523,9 +523,9 @@ public final JSTypedArrayObject typedArrayCreate(Object constr, Object... args)
                 throw Errors.createTypeErrorArrayBufferViewExpected();
             }
             JSTypedArrayObject newTypedArray = (JSTypedArrayObject) newObject;
-            if (JSArrayBufferView.hasDetachedBuffer(newTypedArray, context)) {
+            if (JSArrayBufferView.isOutOfBounds(newTypedArray, context)) {
                 errorBranch.enter();
-                throw Errors.createTypeErrorDetachedBuffer();
+                throw Errors.createTypeErrorOutOfBoundsTypedArray();
             }
             if (args.length == 1 && JSRuntime.isNumber(args[0])) {
                 if (newTypedArray.getLength() < JSRuntime.doubleValue((Number) args[0])) {
@@ -1002,7 +1002,8 @@ protected Object sliceGeneric(Object thisObj, Object begin, Object end,
             Object resultArray = getArraySpeciesConstructorNode().createEmptyContainer(thisArrayObj, size);
             if (sizeIsZero.profile(this, size > 0)) {
                 if (isTypedArrayImplementation) {
-                    checkHasDetachedBuffer((JSDynamicObject) thisObj);
+                    checkOutOfBounds((JSTypedArrayObject) thisObj);
+                    endPos = Math.min(endPos, getLength(thisArrayObj));
                 }
                 forEachIndexCall(thisArrayObj, null, startPos, startPos, endPos, resultArray);
             }
@@ -3065,7 +3066,8 @@ protected Object copyWithin(Object thisObj, Object target, Object start, Object
             long expectedCount = count;
             if (count > 0) {
                 if (isTypedArrayImplementation) {
-                    checkHasDetachedBuffer((JSDynamicObject) thisObj);
+                    checkOutOfBounds((JSTypedArrayObject) thisObj);
+                    len = getLength(obj);
                 }
 
                 long direction;
@@ -3079,6 +3081,9 @@ protected Object copyWithin(Object thisObj, Object target, Object start, Object
 
                 while (count > 0) {
                     if (isTypedArrayImplementation || hasProperty(obj, from)) {
+                        if (isTypedArrayImplementation && (from >= len || to >= len)) {
+                            break;
+                        }
                         Object fromVal = read(obj, from);
                         write(obj, to, fromVal);
                     } else {
@@ -3425,14 +3430,15 @@ protected Object withGeneric(Object thisObj, Object index, Object valueParam) {
             }
 
             if (isTypedArrayImplementation) {
-                if (JSArrayBufferView.isJSArrayBufferView(array) && JSArrayBufferView.isBigIntArrayBufferView((JSDynamicObject) array)) {
+                if (JSArrayBufferView.isBigIntArrayBufferView((JSDynamicObject) array)) {
                     value = toBigInt(value);
                 } else {
                     value = toNumber(value);
                 }
             }
 
-            if (actualIndex >= len || actualIndex < 0) {
+            long lengthForCheck = isTypedArrayImplementation ? (JSArrayBufferView.isOutOfBounds((JSTypedArrayObject) array, getContext()) ? 0 : getLength(thisObj)) : len;
+            if (actualIndex >= lengthForCheck || actualIndex < 0) {
                 errorBranch.enter();
                 throw Errors.createRangeError("invalid index");
             }