[GR-22253] Async iterator's methods should not pass undefined to sync iterator when value is absent.

PullRequest: js/1453

Author: iamstolis

graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/builtins/AsyncFromSyncIteratorPrototypeBuiltins.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2018, 2019, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * The Universal Permissive License (UPL), Version 1.0
@@ -48,6 +48,7 @@
 import com.oracle.truffle.api.nodes.UnexpectedResultException;
 import com.oracle.truffle.api.object.DynamicObject;
 import com.oracle.truffle.api.object.HiddenKey;
+import com.oracle.truffle.api.profiles.ConditionProfile;
 import com.oracle.truffle.js.builtins.AsyncFromSyncIteratorPrototypeBuiltinsFactory.AsyncFromSyncNextNodeGen;
 import com.oracle.truffle.js.builtins.AsyncFromSyncIteratorPrototypeBuiltinsFactory.AsyncFromSyncReturnNodeGen;
 import com.oracle.truffle.js.builtins.AsyncFromSyncIteratorPrototypeBuiltinsFactory.AsyncFromSyncThrowNodeGen;
@@ -132,7 +133,6 @@ private abstract static class AsyncFromSyncBaseNode extends JSBuiltinNode {
         static final HiddenKey DONE = new HiddenKey("Done");
 
         @Child private PropertyGetNode getPromiseNode;
-        @Child private PropertyGetNode getPromiseResolveNode;
 
         @Child private JSFunctionCallNode executePromiseMethodNode;
         @Child private NewPromiseCapabilityNode newPromiseCapabilityNode;
@@ -146,6 +146,8 @@ private abstract static class AsyncFromSyncBaseNode extends JSBuiltinNode {
         @Child protected PropertyGetNode getSyncIteratorRecordNode;
         @Child private PropertySetNode setDoneNode;
 
+        protected ConditionProfile valuePresenceProfile = ConditionProfile.createBinaryProfile();
+
         AsyncFromSyncBaseNode(JSContext context, JSBuiltin builtin) {
             super(context, builtin);
             this.newPromiseCapabilityNode = NewPromiseCapabilityNode.create(context);
@@ -255,7 +257,7 @@ public AsyncFromSyncNext(JSContext context, JSBuiltin builtin) {
         }
 
         @Specialization(guards = "isObject(thisObj)")
-        protected Object next(DynamicObject thisObj, Object value) {
+        protected Object next(VirtualFrame frame, DynamicObject thisObj, Object value) {
             PromiseCapabilityRecord promiseCapability = createPromiseCapability();
             if (!isAsyncFromSyncIterator(thisObj)) {
                 JSException typeError = Errors.createTypeErrorIncompatibleReceiver(thisObj);
@@ -265,7 +267,11 @@ protected Object next(DynamicObject thisObj, Object value) {
             DynamicObject nextResult;
             IteratorRecord syncIteratorRecord = (IteratorRecord) getSyncIteratorRecordNode.getValue(thisObj);
             try {
-                nextResult = iteratorNextNode.execute(syncIteratorRecord, value);
+                if (valuePresenceProfile.profile(JSArguments.getUserArgumentCount(frame.getArguments()) == 0)) {
+                    nextResult = iteratorNextNode.execute(syncIteratorRecord);
+                } else {
+                    nextResult = iteratorNextNode.execute(syncIteratorRecord, value);
+                }
             } catch (GraalJSException e) {
                 promiseCapabilityReject(promiseCapability, e);
                 return promiseCapability.getPromise();
@@ -303,7 +309,11 @@ protected Object doMethod(VirtualFrame frame, DynamicObject thisObj, Object valu
             }
             Object returnResult;
             try {
-                returnResult = executeReturnMethod.executeCall(JSArguments.create(syncIterator, method, value));
+                if (valuePresenceProfile.profile(JSArguments.getUserArgumentCount(frame.getArguments()) == 0)) {
+                    returnResult = executeReturnMethod.executeCall(JSArguments.create(syncIterator, method));
+                } else {
+                    returnResult = executeReturnMethod.executeCall(JSArguments.create(syncIterator, method, value));
+                }
             } catch (GraalJSException e) {
                 promiseCapabilityReject(promiseCapability, e);
                 return promiseCapability.getPromise();

graal-js/test/test262.json

@@ -2,15 +2,15 @@
   "testFiles" : [ {
     "filePath" : "built-ins/AsyncFromSyncIteratorPrototype/next/absent-value-not-passed.js",
     "status" : "FAIL",
-    "comment" : "new failures update 2020-04-01"
+    "comment" : "Incorrect test, see https://github.com/tc39/test262/pull/2551#issuecomment-609595231"
   }, {
     "filePath" : "built-ins/AsyncFromSyncIteratorPrototype/return/absent-value-not-passed.js",
     "status" : "FAIL",
-    "comment" : "new failures update 2020-04-01"
+    "comment" : "Incorrect test, see https://github.com/tc39/test262/pull/2551#issuecomment-609595231"
   }, {
     "filePath" : "built-ins/AsyncFromSyncIteratorPrototype/throw/absent-value-not-passed.js",
     "status" : "FAIL",
-    "comment" : "new failures update 2020-04-01"
+    "comment" : "Incorrect test, see https://github.com/tc39/test262/pull/2551#issuecomment-609595231"
   }, {
     "filePath" : "built-ins/RegExp/property-escapes/generated/Alphabetic.js",
     "status" : "SKIP",