Skip to content

Commit 111870a

Browse files
committed
Disable source caching for eval/Function code.
These do not use Env.parse, so there is not much point in interning the sources.
1 parent f56a2d1 commit 111870a

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

graal-js/src/com.oracle.truffle.js.parser/src/com/oracle/truffle/js/parser/GraalJSEvaluator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ public ScriptNode parseFunction(JSContext context, String parameterList, String
181181
code.append(") {");
182182
code.append(wrappedBody);
183183
code.append("})");
184-
Source source = Source.newBuilder(JavaScriptLanguage.ID, code.toString(), sourceName).build();
184+
Source source = Source.newBuilder(JavaScriptLanguage.ID, code.toString(), sourceName).cached(false).build();
185185
return parseEval(context, null, source, false, null, activeScriptOrModule);
186186
}
187187

graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/builtins/GlobalBuiltins.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1269,7 +1269,7 @@ private ScriptNode parseIndirectEval(JSRealm realm, String sourceCode) {
12691269
Node caller = EvalNode.findCallNode(realm);
12701270
String sourceName = EvalNode.formatEvalOrigin(caller, getContext(), Evaluator.EVAL_SOURCE_NAME);
12711271
ScriptOrModule activeScriptOrModule = EvalNode.findActiveScriptOrModule(caller);
1272-
Source source = Source.newBuilder(JavaScriptLanguage.ID, sourceCode, sourceName).build();
1272+
Source source = Source.newBuilder(JavaScriptLanguage.ID, sourceCode, sourceName).cached(false).build();
12731273
return getContext().getEvaluator().parseEval(getContext(), this, source, activeScriptOrModule);
12741274
}
12751275

graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/nodes/function/EvalNode.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -272,7 +272,7 @@ protected Object directEvalForeignObject(VirtualFrame frame, Object sourceCode,
272272
@TruffleBoundary
273273
private Source sourceFromString(TruffleString sourceCode) {
274274
String evalSourceName = formatEvalOrigin(this, context, Evaluator.EVAL_SOURCE_NAME);
275-
return Source.newBuilder(JavaScriptLanguage.ID, Strings.toJavaString(sourceCode), evalSourceName).build();
275+
return Source.newBuilder(JavaScriptLanguage.ID, Strings.toJavaString(sourceCode), evalSourceName).cached(false).build();
276276
}
277277

278278
protected DirectEvalNode copyUninitialized(Set<Class<? extends Tag>> materializedTags) {

0 commit comments

Comments
 (0)