Skip to content

Commit 15621ed

Browse files
committed
Renaming module record's [[AsyncEvaluating]] to [[AsyncEvaluation]].
1 parent d4f599f commit 15621ed

File tree

3 files changed

+18
-18
lines changed

3 files changed

+18
-18
lines changed

graal-js/src/com.oracle.truffle.js.parser/src/com/oracle/truffle/js/parser/GraalJSEvaluator.java

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -688,7 +688,7 @@ public Object moduleEvaluation(JSRealm realm, JSModuleRecord moduleRecord) {
688688
innerModuleEvaluation(realm, module, stack, 0);
689689
assert module.getStatus() == Status.Evaluated;
690690
assert module.getEvaluationError() == null;
691-
if (!module.isAsyncEvaluating()) {
691+
if (!module.isAsyncEvaluation()) {
692692
JSFunction.call(JSArguments.create(Undefined.instance, capability.getResolve(), Undefined.instance));
693693
}
694694
assert stack.isEmpty();
@@ -769,14 +769,14 @@ private int innerModuleEvaluation(JSRealm realm, JSModuleRecord moduleRecord, De
769769
throw JSRuntime.rethrow(moduleRecord.getEvaluationError());
770770
}
771771
}
772-
if (requiredModule.isAsyncEvaluating()) {
772+
if (requiredModule.isAsyncEvaluation()) {
773773
moduleRecord.incPendingAsyncDependencies();
774774
requiredModule.appendAsyncParentModules(moduleRecord);
775775
}
776776
}
777777
if (moduleRecord.getPendingAsyncDependencies() > 0 || moduleRecord.hasTLA()) {
778-
assert !moduleRecord.isAsyncEvaluating() && moduleRecord.getAsyncEvaluatingOrder() == 0;
779-
moduleRecord.setAsyncEvaluating(true);
778+
assert !moduleRecord.isAsyncEvaluation() && moduleRecord.getAsyncEvaluatingOrder() == 0;
779+
moduleRecord.setAsyncEvaluation(true);
780780
moduleRecord.setAsyncEvaluatingOrder(realm.nextAsyncEvaluationOrder());
781781
if (moduleRecord.getPendingAsyncDependencies() == 0) {
782782
moduleAsyncExecution(realm, moduleRecord);
@@ -876,7 +876,7 @@ private static void gatherAvailableAncestors(JSModuleRecord module, Set<JSModule
876876
for (JSModuleRecord m : module.getAsyncParentModules()) {
877877
if (!execList.contains(m) && m.getCycleRoot().getEvaluationError() == null) {
878878
assert m.getEvaluationError() == null;
879-
assert m.isAsyncEvaluating();
879+
assert m.isAsyncEvaluation();
880880
assert m.getPendingAsyncDependencies() > 0;
881881
m.decPendingAsyncDependencies();
882882
if (m.getPendingAsyncDependencies() == 0) {
@@ -891,9 +891,9 @@ private static void gatherAvailableAncestors(JSModuleRecord module, Set<JSModule
891891

892892
@TruffleBoundary
893893
private static Object asyncModuleExecutionFulfilled(JSRealm realm, JSModuleRecord module, Object dynamicImportResolutionResult) {
894-
assert module.isAsyncEvaluating();
894+
assert module.isAsyncEvaluation();
895895
assert module.getEvaluationError() == null;
896-
module.setAsyncEvaluating(false);
896+
module.setAsyncEvaluation(false);
897897
if (module.getTopLevelCapability() != null) {
898898
assert module.getCycleRoot() == module;
899899
JSFunction.call(JSArguments.create(Undefined.instance, module.getTopLevelCapability().getResolve(), dynamicImportResolutionResult));
@@ -906,14 +906,14 @@ public int compare(JSModuleRecord o1, JSModuleRecord o2) {
906906
});
907907
gatherAvailableAncestors(module, execList);
908908
for (JSModuleRecord m : execList) {
909-
if (!m.isAsyncEvaluating()) {
909+
if (!m.isAsyncEvaluation()) {
910910
assert m.getEvaluationError() != null;
911911
} else if (m.hasTLA()) {
912912
moduleAsyncExecution(realm, m);
913913
} else {
914914
try {
915915
moduleExecution(realm, m, null);
916-
m.setAsyncEvaluating(false);
916+
m.setAsyncEvaluation(false);
917917
if (m.getTopLevelCapability() != null) {
918918
assert m.getCycleRoot() == m;
919919
JSFunction.call(JSArguments.create(Undefined.instance, m.getTopLevelCapability().getResolve(), dynamicImportResolutionResult));
@@ -930,13 +930,13 @@ public int compare(JSModuleRecord o1, JSModuleRecord o2) {
930930
private static Object asyncModuleExecutionRejected(JSRealm realm, JSModuleRecord module, Object error) {
931931
assert error != null : "Cannot reject a module creation with null error";
932932
assert module.getStatus() == Status.Evaluated;
933-
if (!module.isAsyncEvaluating()) {
933+
if (!module.isAsyncEvaluation()) {
934934
assert module.getEvaluationError() != null;
935935
return Undefined.instance;
936936
}
937937
assert module.getEvaluationError() == null;
938938
module.setEvaluationError(JSRuntime.getException(error));
939-
module.setAsyncEvaluating(false);
939+
module.setAsyncEvaluation(false);
940940
for (JSModuleRecord m : module.getAsyncParentModules()) {
941941
asyncModuleExecutionRejected(realm, m, error);
942942
}

graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/nodes/promise/ImportCallNode.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -365,7 +365,7 @@ public Object execute(VirtualFrame frame) {
365365
promiseThenNode.execute((DynamicObject) innerPromise, resolve, reject, moduleLoadedCapability);
366366
} else {
367367
Object result = finishDynamicImport(realm, moduleRecord, referencingScriptOrModule, moduleRequest);
368-
if (moduleRecord.isAsyncEvaluating()) {
368+
if (moduleRecord.isAsyncEvaluation()) {
369369
// Some module import started an async loading chain. The top-level
370370
// capability will reject/resolve the dynamic import promise.
371371
PromiseCapabilityRecord topLevelCapability = moduleRecord.getTopLevelCapability();

graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/runtime/objects/JSModuleRecord.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -243,8 +243,8 @@ public void setUninstantiated() {
243243
private JSModuleRecord cycleRoot = this;
244244
// [[HasTLA]]
245245
private final boolean hasTLA;
246-
// [[AsyncEvaluating]]
247-
private boolean asyncEvaluating = false;
246+
// [[AsyncEvaluation]]
247+
private boolean asyncEvaluation = false;
248248
private long asyncEvaluatingOrder;
249249
// [[TopLevelCapability]]
250250
private PromiseCapabilityRecord topLevelPromiseCapability = null;
@@ -261,8 +261,8 @@ public void setTopLevelCapability(PromiseCapabilityRecord capability) {
261261
this.topLevelPromiseCapability = capability;
262262
}
263263

264-
public boolean isAsyncEvaluating() {
265-
return asyncEvaluating;
264+
public boolean isAsyncEvaluation() {
265+
return asyncEvaluation;
266266
}
267267

268268
public List<JSModuleRecord> getAsyncParentModules() {
@@ -294,8 +294,8 @@ public int getPendingAsyncDependencies() {
294294
return pendingAsyncDependencies;
295295
}
296296

297-
public void setAsyncEvaluating(boolean value) {
298-
asyncEvaluating = value;
297+
public void setAsyncEvaluation(boolean value) {
298+
asyncEvaluation = value;
299299
}
300300

301301
public void setAsyncEvaluatingOrder(long order) {

0 commit comments

Comments
 (0)