[GR-49957] Correction of Number.isFinite/is(Safe)Integer(long).

PullRequest: js/2977

Author: iamstolis

graal-js/src/com.oracle.truffle.js.test/js/GR-49957.js

@@ -0,0 +1,24 @@
+/*
+ * Copyright (c) 2023, 2023, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * Licensed under the Universal Permissive License v 1.0 as shown at http://oss.oracle.com/licenses/upl.
+ */
+
+load("assert.js");
+
+var minValue = java.lang.Long.MIN_VALUE;
+var maxValue = java.lang.Long.MAX_VALUE;
+var someValue = java.lang.Long.parseLong("12345678901");
+
+assertTrue(Number.isFinite(minValue));
+assertTrue(Number.isFinite(maxValue));
+assertTrue(Number.isFinite(someValue));
+
+assertTrue(Number.isInteger(minValue));
+assertTrue(Number.isInteger(maxValue));
+assertTrue(Number.isInteger(someValue));
+
+assertFalse(Number.isSafeInteger(minValue));
+assertFalse(Number.isSafeInteger(maxValue));
+assertTrue(Number.isSafeInteger(someValue));

graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/builtins/NumberFunctionBuiltins.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2018, 2023, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * The Universal Permissive License (UPL), Version 1.0
@@ -134,12 +134,17 @@ protected boolean isFinite(@SuppressWarnings("unused") int arg) {
             return true;
         }
 
+        @Specialization
+        protected boolean isFinite(@SuppressWarnings("unused") long arg) {
+            return true;
+        }
+
         @Specialization
         protected boolean isFinite(double arg) {
             return Double.isFinite(arg);
         }
 
-        @Specialization(guards = "!isNumber(arg)")
+        @Specialization(guards = {"!isNumber(arg)", "!isNumberLong(arg)"})
         protected boolean isFinite(@SuppressWarnings("unused") Object arg) {
             return false;
         }
@@ -157,6 +162,12 @@ protected static boolean isInteger(int arg) {
             return true;
         }
 
+        @SuppressWarnings("unused")
+        @Specialization
+        protected static boolean isInteger(long arg) {
+            return true;
+        }
+
         @SuppressWarnings("unused")
         @Specialization
         protected static boolean isInteger(SafeInteger arg) {
@@ -169,7 +180,7 @@ protected static boolean isInteger(double arg) {
         }
 
         @SuppressWarnings("unused")
-        @Specialization(guards = "!isNumber(arg)")
+        @Specialization(guards = {"!isNumber(arg)", "!isNumberLong(arg)"})
         protected static boolean isInteger(Object arg) {
             return false;
         }
@@ -186,6 +197,16 @@ protected boolean isSafeIntegerInt(@SuppressWarnings("unused") int arg) {
             return true;
         }
 
+        @Specialization
+        protected boolean isSafeIntegerLong(long arg) {
+            return JSRuntime.isSafeInteger(arg);
+        }
+
+        @Specialization
+        protected boolean isSafeIntegerSafeInteger(@SuppressWarnings("unused") SafeInteger arg) {
+            return true;
+        }
+
         @Specialization
         protected boolean isSafeIntegerDouble(double arg) {
             if (!JSRuntime.isIntegralNumber(arg)) {
@@ -195,7 +216,7 @@ protected boolean isSafeIntegerDouble(double arg) {
             return JSRuntime.MIN_SAFE_INTEGER <= l && l <= JSRuntime.MAX_SAFE_INTEGER;
         }
 
-        @Specialization(guards = "!isNumber(arg)")
+        @Specialization(guards = {"!isNumber(arg)", "!isNumberLong(arg)"})
         protected boolean isSafeIntegerNotANumber(@SuppressWarnings("unused") Object arg) {
             return false;
         }