ArrayBufferView with a detached buffer does not have indices.

iamstolis · woess · commit 36aefe4e6bd3 · 2023-09-11T03:44:34.000+02:00
diff --git a/graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/runtime/builtins/JSArrayBufferView.java b/graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/runtime/builtins/JSArrayBufferView.java
@@ -441,8 +441,11 @@ public List<Object> getOwnPropertyKeys(JSDynamicObject thisObj, boolean strings,
         if (!strings) {
             return super.getOwnPropertyKeys(thisObj, strings, symbols);
         }
-        List<Object> indices = typedArrayGetArrayType(thisObj).ownPropertyKeys(thisObj);
         List<Object> keys = ordinaryOwnPropertyKeys(thisObj, strings, symbols);
+        if (hasDetachedBuffer(thisObj)) {
+            return keys;
+        }
+        List<Object> indices = typedArrayGetArrayType(thisObj).ownPropertyKeys(thisObj);
         return IteratorUtil.concatLists(indices, keys);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -441,8 +441,11 @@ public List<Object> getOwnPropertyKeys(JSDynamicObject thisObj, boolean strings,`
`441`	`441`	`if (!strings) {`
`442`	`442`	`return super.getOwnPropertyKeys(thisObj, strings, symbols);`
`443`	`443`	`}`
`444`		`- List<Object> indices = typedArrayGetArrayType(thisObj).ownPropertyKeys(thisObj);`
`445`	`444`	`List<Object> keys = ordinaryOwnPropertyKeys(thisObj, strings, symbols);`
	`445`	`+ if (hasDetachedBuffer(thisObj)) {`
	`446`	`+ return keys;`
	`447`	`+ }`
	`448`	`+ List<Object> indices = typedArrayGetArrayType(thisObj).ownPropertyKeys(thisObj);`
`446`	`449`	`return IteratorUtil.concatLists(indices, keys);`
`447`	`450`	`}`
`448`	`451`