Skip to content

Commit 53ceb45

Browse files
OracleLabsAutomationelkorchi
authored andcommitted
[GR-64708] Backport to 24.2: ExportValueNode.doTruffleObject() should exclude SafeIntegers.
PullRequest: js/3499
2 parents 0c22a18 + 3db26f0 commit 53ceb45

File tree

3 files changed

+74
-2
lines changed

3 files changed

+74
-2
lines changed
Lines changed: 67 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,67 @@
1+
/*
2+
* Copyright (c) 2025, 2025, Oracle and/or its affiliates. All rights reserved.
3+
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
4+
*
5+
* The Universal Permissive License (UPL), Version 1.0
6+
*
7+
* Subject to the condition set forth below, permission is hereby granted to any
8+
* person obtaining a copy of this software, associated documentation and/or
9+
* data (collectively the "Software"), free of charge and under any and all
10+
* copyright rights in the Software, and any and all patent rights owned or
11+
* freely licensable by each licensor hereunder covering either (i) the
12+
* unmodified Software as contributed to or provided by such licensor, or (ii)
13+
* the Larger Works (as defined below), to deal in both
14+
*
15+
* (a) the Software, and
16+
*
17+
* (b) any piece of software and/or hardware listed in the lrgrwrks.txt file if
18+
* one is included with the Software each a "Larger Work" to which the Software
19+
* is contributed by such licensors),
20+
*
21+
* without restriction, including without limitation the rights to copy, create
22+
* derivative works of, display, perform, and distribute the Software and make,
23+
* use, sell, offer for sale, import, export, have made, and have sold the
24+
* Software and the Larger Work(s), and to sublicense the foregoing rights on
25+
* either these or other terms.
26+
*
27+
* This license is subject to the following condition:
28+
*
29+
* The above copyright notice and either this complete permission notice or at a
30+
* minimum a reference to the UPL must be included in all copies or substantial
31+
* portions of the Software.
32+
*
33+
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
34+
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
35+
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
36+
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
37+
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
38+
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
39+
* SOFTWARE.
40+
*/
41+
package com.oracle.truffle.js.test.regress;
42+
43+
import static org.junit.Assert.assertFalse;
44+
import static org.junit.Assert.assertTrue;
45+
46+
import org.graalvm.polyglot.Context;
47+
import org.graalvm.polyglot.Value;
48+
import org.junit.Test;
49+
50+
import com.oracle.truffle.js.runtime.SafeInteger;
51+
import com.oracle.truffle.js.test.JSTest;
52+
53+
public class GR64695 {
54+
55+
@Test
56+
public void testIt() {
57+
try (Context ctx = JSTest.newContextBuilder().allowAllAccess(true).build()) {
58+
String code = "var counter = 0; (function() { return counter++ ? 314159265358979 : java.lang.Object; })";
59+
Value fn = ctx.eval("js", code);
60+
assertTrue(fn.execute().isHostObject());
61+
Object value = fn.execute().as(Object.class);
62+
assertTrue(value instanceof Number);
63+
assertFalse(value instanceof SafeInteger);
64+
}
65+
}
66+
67+
}

graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/nodes/JSGuards.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@
4646
import com.oracle.truffle.api.strings.TruffleString;
4747
import com.oracle.truffle.js.runtime.BigInt;
4848
import com.oracle.truffle.js.runtime.JSRuntime;
49+
import com.oracle.truffle.js.runtime.SafeInteger;
4950
import com.oracle.truffle.js.runtime.Strings;
5051
import com.oracle.truffle.js.runtime.Symbol;
5152
import com.oracle.truffle.js.runtime.builtins.JSAbstractArgumentsArray;
@@ -407,6 +408,10 @@ public static boolean isJavaArray(Object value) {
407408
return value != null && value.getClass().isArray();
408409
}
409410

411+
public static boolean isSafeInteger(Object target) {
412+
return target instanceof SafeInteger;
413+
}
414+
410415
public static boolean isBigInt(Object target) {
411416
return target instanceof BigInt;
412417
}

graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/nodes/interop/ExportValueNode.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (c) 2018, 2024, Oracle and/or its affiliates. All rights reserved.
2+
* Copyright (c) 2018, 2025, Oracle and/or its affiliates. All rights reserved.
33
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
44
*
55
* The Universal Permissive License (UPL), Version 1.0
@@ -155,7 +155,7 @@ protected static TruffleString doString(TruffleString value, @SuppressWarnings("
155155
return value;
156156
}
157157

158-
@Specialization(guards = {"!isJSFunction(value)"}, replaces = "doObject")
158+
@Specialization(guards = {"!isJSFunction(value)", "!isSafeInteger(value)"}, replaces = "doObject")
159159
protected static TruffleObject doTruffleObject(TruffleObject value, @SuppressWarnings("unused") Object thiz, @SuppressWarnings("unused") boolean bindFunctions) {
160160
return value;
161161
}

0 commit comments

Comments
 (0)