Skip to content

Commit 56ac119

Browse files
committed
Add error message test.
(cherry picked from commit 5845cfa)
1 parent 6d11904 commit 56ac119

File tree

1 file changed

+118
-0
lines changed

1 file changed

+118
-0
lines changed
Lines changed: 118 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,118 @@
1+
/*
2+
* Copyright (c) 2025, Oracle and/or its affiliates. All rights reserved.
3+
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
4+
*
5+
* The Universal Permissive License (UPL), Version 1.0
6+
*
7+
* Subject to the condition set forth below, permission is hereby granted to any
8+
* person obtaining a copy of this software, associated documentation and/or
9+
* data (collectively the "Software"), free of charge and under any and all
10+
* copyright rights in the Software, and any and all patent rights owned or
11+
* freely licensable by each licensor hereunder covering either (i) the
12+
* unmodified Software as contributed to or provided by such licensor, or (ii)
13+
* the Larger Works (as defined below), to deal in both
14+
*
15+
* (a) the Software, and
16+
*
17+
* (b) any piece of software and/or hardware listed in the lrgrwrks.txt file if
18+
* one is included with the Software each a "Larger Work" to which the Software
19+
* is contributed by such licensors),
20+
*
21+
* without restriction, including without limitation the rights to copy, create
22+
* derivative works of, display, perform, and distribute the Software and make,
23+
* use, sell, offer for sale, import, export, have made, and have sold the
24+
* Software and the Larger Work(s), and to sublicense the foregoing rights on
25+
* either these or other terms.
26+
*
27+
* This license is subject to the following condition:
28+
*
29+
* The above copyright notice and either this complete permission notice or at a
30+
* minimum a reference to the UPL must be included in all copies or substantial
31+
* portions of the Software.
32+
*
33+
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
34+
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
35+
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
36+
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
37+
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
38+
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
39+
* SOFTWARE.
40+
*/
41+
package com.oracle.truffle.js.test.builtins;
42+
43+
import org.graalvm.polyglot.Context;
44+
import org.graalvm.polyglot.PolyglotException;
45+
import org.graalvm.polyglot.Value;
46+
import org.junit.Assert;
47+
import org.junit.Test;
48+
49+
import com.oracle.truffle.js.lang.JavaScriptLanguage;
50+
import com.oracle.truffle.js.test.JSTest;
51+
52+
public class ErrorMessageTest {
53+
54+
/**
55+
* GR-63023: Provide a better error message by querying error name and message properties.
56+
*/
57+
@Test
58+
public void testErrorNameAndMessage() {
59+
for (boolean as : new boolean[]{false, true}) {
60+
try (Context context = JSTest.newContextBuilder().build()) {
61+
Value customErrorClass = context.eval(JavaScriptLanguage.ID, """
62+
class CustomError extends Error {
63+
constructor(initialMessage, name, message) {
64+
super(initialMessage ?? undefined);
65+
if (name != undefined) {
66+
this.name = name;
67+
}
68+
if (message != undefined) {
69+
this.message = message;
70+
}
71+
}
72+
}
73+
CustomError;
74+
""");
75+
76+
Value errorObject;
77+
PolyglotException polyglotException;
78+
// override name and message
79+
errorObject = customErrorClass.newInstance("initial message", "ExpectedError", "expected message");
80+
polyglotException = asPolyglotException(errorObject, as);
81+
Assert.assertEquals("ExpectedError: expected message", polyglotException.getMessage());
82+
83+
// override only message
84+
errorObject = customErrorClass.newInstance("initial message", null, "expected message");
85+
polyglotException = asPolyglotException(errorObject, as);
86+
Assert.assertEquals("CustomError: expected message", polyglotException.getMessage());
87+
88+
// override only name
89+
errorObject = customErrorClass.newInstance("initial message", "ExpectedError");
90+
polyglotException = asPolyglotException(errorObject, as);
91+
Assert.assertEquals("ExpectedError: initial message", polyglotException.getMessage());
92+
93+
// override only name, no message
94+
errorObject = customErrorClass.newInstance(null, "ExpectedError");
95+
polyglotException = asPolyglotException(errorObject, as);
96+
Assert.assertEquals("ExpectedError", polyglotException.getMessage());
97+
98+
// override none
99+
errorObject = customErrorClass.newInstance("initial message");
100+
polyglotException = asPolyglotException(errorObject, as);
101+
Assert.assertEquals("CustomError: initial message", polyglotException.getMessage());
102+
}
103+
}
104+
}
105+
106+
private static PolyglotException asPolyglotException(Value exception, boolean as) {
107+
if (as) {
108+
return exception.as(PolyglotException.class);
109+
} else {
110+
try {
111+
exception.throwException();
112+
throw new AssertionError("Expected PolyglotException");
113+
} catch (PolyglotException polyglotException) {
114+
return polyglotException;
115+
}
116+
}
117+
}
118+
}

0 commit comments

Comments
 (0)